From: Jonathan Nieder <jrnieder@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/2] bash: add helper function to get config variables for completion
Date: Thu, 14 Oct 2010 12:15:07 -0500 [thread overview]
Message-ID: <20101014171507.GA17550@burratino> (raw)
In-Reply-To: <1287046727-22509-1-git-send-email-szeder@ira.uka.de>
SZEDER Gábor wrote:
> Currently there are three completion functions that perform similar
> queries to 'git config' to get config variable names.
Good point.
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -451,10 +451,7 @@ __git_remotes ()
> echo ${i#$d/remotes/}
> done
> [ "$ngoff" ] && shopt -u nullglob
> - for i in $(git --git-dir="$d" config --get-regexp 'remote\..*\.url' 2>/dev/null); do
> - i="${i#remote.}"
> - echo "${i/.url*/}"
> - done
> + __git_get_config_variables "remote" "url"
> }
Ok, so __git_get_config_variables $category $var means something like
git config --get-regexp '$category[.].*[.]$var' |
cut -d. -f2
> @@ -750,14 +747,16 @@ __git_compute_porcelain_commands ()
> : ${__git_porcelain_commands:=$(__git_list_porcelain_commands)}
> }
>
> -__git_aliases ()
> +# returns all config variables within a given section with an optional
> +# suffix, with both the section name and the suffix removed
> +__git_get_config_variables ()
> {
> - local i IFS=$'\n'
> - for i in $(git --git-dir="$(__gitdir)" config --get-regexp "alias\..*" 2>/dev/null); do
> + local section="$1" suffix="${2-}" i IFS=$'\n'
> + for i in $(git --git-dir="$(__gitdir)" config --get-regexp "$section\..*${suffix:+\.$suffix}" 2>/dev/null); do
Would it be possible to shorten this line? e.g.
for i in $(
git --git-dir="$(__gitdir)" ...
); do
or
while read -r setting
do
...
done < <(
git --git-dir="$(__gitdir)" ...
)
or
local ... IFS=$'\n'
set -- $(git ... )
for i do
...
done
next prev parent reply other threads:[~2010-10-14 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 21:34 [PATCH] bash: support pretty format aliases SZEDER Gábor
2010-10-10 21:44 ` Jonathan Nieder
2010-10-10 22:06 ` [PATCH v2] " SZEDER Gábor
2010-10-14 8:55 ` SZEDER Gábor
2010-10-14 8:58 ` [PATCH 1/2] bash: add helper function to get config variables for completion SZEDER Gábor
2010-10-14 17:15 ` Jonathan Nieder [this message]
2010-10-20 22:29 ` SZEDER Gábor
2010-10-14 8:58 ` [PATCH 2/2] bash: support pretty format aliases SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014171507.GA17550@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).