From: Yann Dirson <ydirson@free.fr>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Yann Dirson <dirson@bertin.fr>, Santi B?jar <santi@agolina.net>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] Re: Undocumented git-diff syntax
Date: Mon, 11 Oct 2010 20:52:50 +0200 [thread overview]
Message-ID: <20101011185250.GC4983@home.lan> (raw)
In-Reply-To: <20101011160224.GA25842@burratino>
On Mon, Oct 11, 2010 at 11:02:24AM -0500, Jonathan Nieder wrote:
> Yann Dirson wrote:
>
> > OTOH, that appears not to be 100% accurate (my tests would have
> > shown me): although --no-index does give me the expected results when
> > one or two of the files are untracked, I have to explicitely add it,
> > which seem to contradict this part of the doc.
>
> Yep, the doc is out of date. Luckily I had a series updating it
> rotting in my local tree.
>
> Patch 5 gives --no-index its own prominent mention in the DESCRIPTION
> section. I suspect that is a bad idea --- too much to learn for new
> users --- and that the description should go under OPTIONS, but I ran
> out of time.
OTOH, not making it prominent does not help users to realize it is
there. Keeping it last, or maybe in a "less frequently used" section
looks fine to me - eg. the <commit>...<commit> form could join it into
such a section
> Maybe patches 1-4 can help?
They make things much more clear, thanks.
So it looks like after this doc patch series, we're left with a couple
of bugs:
* the "fatal: '../Makefile' is outside repository" seen by Santi
* the following which should probably complain that the files cannot
be compared:
$ echo a>a;echo b>b
$ git diff a b; echo $?
0
At least, I can't think of them as meaningful behaviours.
Best regards,
--
Yann
next prev parent reply other threads:[~2010-10-11 18:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 13:03 Undocumented git-diff syntax Yann Dirson
2010-10-11 13:59 ` Santi Béjar
2010-10-11 14:17 ` Yann Dirson
2010-10-11 14:52 ` Santi Béjar
2010-10-11 16:02 ` [PATCH 0/4] " Jonathan Nieder
2010-10-11 16:03 ` [PATCH 1/5] Documentation: gitrevisions is in section 7 Jonathan Nieder
2010-10-11 20:49 ` Sverre Rabbelier
2010-10-11 16:04 ` [PATCH 2/4] Documentation: diff can compare blobs Jonathan Nieder
2010-10-11 16:05 ` [PATCH 3/4] Documentation: expand 'git diff' SEE ALSO section Jonathan Nieder
2010-10-11 16:06 ` [PATCH 4/4] Documentation: update "git diff --no-index" description Jonathan Nieder
2010-10-11 16:07 ` [RFC/PATCH 5/4] Documentation: flesh out diff --no-index description Jonathan Nieder
2010-10-13 22:40 ` Junio C Hamano
2010-10-11 18:52 ` Yann Dirson [this message]
2010-10-11 20:56 ` [PATCH 0/4] Re: Undocumented git-diff syntax Sverre Rabbelier
2010-10-11 16:57 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011185250.GC4983@home.lan \
--to=ydirson@free.fr \
--cc=dirson@bertin.fr \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).