From: Jonathan Nieder <jrnieder@gmail.com>
To: "Tomáš Ebenlendr" <ebik@ucw.cz>
Cc: Eric Wong <normalperson@yhbt.net>, git@vger.kernel.org
Subject: Re: [PATCH] git-svn.perl: Fix glob matching on svn paths
Date: Sun, 10 Oct 2010 01:15:35 -0500 [thread overview]
Message-ID: <20101010061534.GB23100@burratino> (raw)
In-Reply-To: <1286615236-29732-2-git-send-email-ebik@ucw.cz>
Hi Tomáš,
Tomáš Ebenlendr wrote:
> I tried to convert our repositories to git. Our repositories have only
> branches (no tags, and no branch is so special to be called trunk).
> The directory of each individual branch live in the root of the
> repository (i.e., not in directory 'branches' as in standard layout).
Okay, so I am imagining:
1.0.x/
1.1.x/
1.2.x/
2.0.x/
...
> I init the repository by: git svn init path_to_repo -b *
> This triggers first bogus match in match_globs(): the pattern matches an
> empty string - the place before first slash in any path.
A branches refspec of
*:refs/remotes/*
results in
$self{left} = ''
$self{glob} = '*'
$self{left_regex} = qr'^/(/|$)'
$self{regex} = qr'([^/]*)'.
Does get_dir_globbed cope correctly? Will get_dir cope correctly with
the spurious / (from $left/$de) inserted at the beginning of paths?
The regex always matches, even for empty $p, but it is not immediately
obvious to me how that pans out. Could you describe the symptoms?
> We have created some branch names just by adding some suffix to another
> branch name. Imagine branch "devel" and "devel2". Then there is bogus
> match on path '/devel2' as it outputs 'devel'.
Is this problem reproducible without the other change? If so, would
it makes sense to split off this fix as a separate patch?
Also, if Eric likes your patches, can he forge your sign-off? See
Documentation/SubmittingPatches for what this means.
Thanks,
Jonathan
next prev parent reply other threads:[~2010-10-10 6:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 9:07 git-svn.perl: Fix glob matching on svn paths Tomáš Ebenlendr
2010-10-09 9:07 ` [PATCH] " Tomáš Ebenlendr
2010-10-10 6:15 ` Jonathan Nieder [this message]
2010-10-14 9:34 ` ebik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010061534.GB23100@burratino \
--to=jrnieder@gmail.com \
--cc=ebik@ucw.cz \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).