From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Jon Seymour <jon.seymour@gmail.com>, Kevin Ballard <kevin@sb.org>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] Submodules: Add the new "fetch" config option for fetch and pull
Date: Sat, 9 Oct 2010 14:54:46 -0500 [thread overview]
Message-ID: <20101009195446.GA19064@burratino> (raw)
In-Reply-To: <4CB0C0DC.40108@web.de>
Jens Lehmann wrote:
> Am 07.10.2010 15:33, schrieb Jon Seymour:
>> I wonder if the name is a little too general for the function of this
>> configuration variable and if it might not be better to qualify it a
>> little further, perhaps
>> with the recursive suffix, e.g.:
>>
>> submodule.<name>.fetch.recursive
>>
>> This would allow us to define other attributes that configure fetch on
>> a per submodule basis later should the need arise.
>
> I think that's a valid point (especially as we might add the --recursive
> option to other commands too). I will change the option name as proposed
> in the next version.
That would look like
[submodule "<name>"]
fetch.recursive = ...
in files with .git/config syntax. Maybe fetchRecursive or similar
would be more consistent with existing variables?
I'm not personally invested in any name; just thought that reminder
might be useful.
next prev parent reply other threads:[~2010-10-09 19:58 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:49 [RFC PATCH 0/2] Teach fetch and pull to recursively fetch submodules too Jens Lehmann
2010-08-29 15:50 ` [PATCH 1/2] fetch/pull: Recursively fetch populated submodules Jens Lehmann
2010-08-29 15:51 ` [PATCH 2/2] Submodules: Add the new "fetch" config option Jens Lehmann
2010-08-30 7:34 ` Junio C Hamano
2010-08-30 17:37 ` [PATCH 2/2 v2] Submodules: Add the new "fetch" config option for fetch and pull Jens Lehmann
2010-08-29 17:29 ` [RFC PATCH 0/2] Teach fetch and pull to recursively fetch submodules too Ævar Arnfjörð Bjarmason
2010-08-29 22:34 ` Jens Lehmann
2010-08-30 5:58 ` Junio C Hamano
2010-08-30 17:41 ` Jens Lehmann
2010-09-15 0:18 ` Kevin Ballard
2010-09-15 2:40 ` Kevin Ballard
2010-09-16 13:55 ` [PATCH] fetch: Get submodule paths from index and not from .gitmodules Jens Lehmann
2010-09-16 19:29 ` Kevin Ballard
2010-09-17 11:31 ` Jens Lehmann
2010-09-17 12:06 ` Johannes Sixt
2010-09-17 12:22 ` Jens Lehmann
2010-09-17 12:32 ` Johannes Sixt
2010-09-17 14:01 ` Jens Lehmann
2010-09-17 14:14 ` Johannes Sixt
2010-09-18 0:29 ` Kevin Ballard
2010-09-18 22:32 ` [PATCH 0/2] fix problems with recursive submodule fetching Jens Lehmann
2010-09-18 22:33 ` [PATCH 1/2] fetch: Fix a bug swallowing the output of " Jens Lehmann
2010-09-18 22:35 ` [PATCH 2/2] fetch: Get submodule paths from index and not from .gitmodules Jens Lehmann
2010-09-19 3:54 ` [PATCH 0/2] fix problems with recursive submodule fetching Kevin Ballard
2010-09-19 16:40 ` Jens Lehmann
2010-09-20 6:40 ` Kevin Ballard
2010-10-05 20:43 ` [PATCH v2 0/3] Teach fetch and pull to recursively fetch submodules too Jens Lehmann
2010-10-05 20:43 ` [PATCH 1/3] fetch/pull: Recursively fetch populated submodules Jens Lehmann
2010-10-05 20:44 ` [PATCH 2/3] Submodules: Add the new "fetch" config option for fetch and pull Jens Lehmann
2010-10-07 13:33 ` Jon Seymour
2010-10-09 19:22 ` Jens Lehmann
2010-10-09 19:54 ` Jonathan Nieder [this message]
2010-10-09 20:12 ` Jens Lehmann
2010-10-05 20:45 ` [PATCH 3/3] Add the 'fetch.recursive' config setting Jens Lehmann
2010-10-05 21:06 ` [PATCH v2 0/3] Teach fetch and pull to recursively fetch submodules too Junio C Hamano
2010-10-06 22:52 ` Kevin Ballard
2010-10-06 23:22 ` Jonathan Nieder
2010-10-09 19:28 ` Jens Lehmann
2010-10-09 20:02 ` Jonathan Nieder
2010-10-09 20:37 ` Jens Lehmann
2010-10-21 18:29 ` Jonathan Nieder
2010-10-21 21:15 ` Jens Lehmann
2010-10-09 19:17 ` Jens Lehmann
2010-10-13 14:48 ` Marc Branchaud
2010-10-13 19:32 ` Jens Lehmann
2010-10-13 19:34 ` Kevin Ballard
2010-10-13 20:06 ` Jens Lehmann
2010-10-13 20:11 ` Kevin Ballard
2010-10-14 1:01 ` Chris Packham
2010-10-14 18:14 ` Jens Lehmann
2010-10-14 18:31 ` Chris Packham
2010-10-13 21:27 ` Marc Branchaud
2010-10-13 21:31 ` Kevin Ballard
2010-09-15 11:32 ` [RFC PATCH 0/2] " Jens Lehmann
2010-09-15 23:12 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009195446.GA19064@burratino \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).