From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv5 04/12] gitweb: nagivation menu for tags, heads and remotes
Date: Sun, 26 Sep 2010 19:52:07 +0200 [thread overview]
Message-ID: <201009261952.07803.jnareb@gmail.com> (raw)
In-Reply-To: <1285344167-8518-5-git-send-email-giuseppe.bilotta@gmail.com>
On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:
> tags, heads and remotes are all views that inspect a (particular class
> of) refs, so allow the user to easily switch between them by adding
> the appropriate navigation submenu to each view.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Nice idea. FWIW
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
> gitweb/gitweb.perl | 20 +++++++++++++++++---
> 1 files changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index fe9f73e..c3ce7a3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3721,6 +3721,20 @@ sub git_print_page_nav {
> "</div>\n";
> }
>
> +# returns a submenu for the nagivation of the refs views (tags, heads,
> +# remotes) with the current view disabled and the remotes view only
> +# available if the feature is enabled
> +
Minor nitpick: this empty line here is not necessary. But I think
that Junio can remove it when applying.
> +sub format_ref_views {
> + my ($current) = @_;
> + my @ref_views = qw{tags heads};
Hmmm... should we pass it as argument, or use $action in place of
$current? Each solution has its advantages and disadvantages. Current
solution has the advantage of avoiding using global variables, solution
using $action has the (supposed) advantage of automatically detecting
current action.
I would probably write
+ my $current) = shift;
+ my @ref_views = qw(tags heads);
but it makes no difference, and this style is also good.
> + push @ref_views, 'remotes' if gitweb_check_feature('remote_heads');
> + return join " | ", map {
> + $_ eq $current ? $_ :
> + $cgi->a({-href => href(action=>$_, -replay=>1)}, $_)
> + } @ref_views
> +}
[...]
> - git_print_page_nav('','', $head,undef,$head);
> + git_print_page_nav('','', $head,undef,$head,format_ref_views('tags'));
> - git_print_page_nav('','', $head,undef,$head);
> + git_print_page_nav('','', $head,undef,$head,format_ref_views('heads'));
> - git_print_page_nav('','', $head,undef,$head);
> + git_print_page_nav('','', $head,undef,$head,format_ref_views('remotes'));
Nice API. I like it.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-09-26 17:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 16:02 [PATCHv5 00/12] gitweb: remote_heads feature Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 01/12] gitweb: introduce " Giuseppe Bilotta
2010-09-26 17:24 ` Jakub Narebski
2010-09-26 19:19 ` Ævar Arnfjörð Bjarmason
2010-09-26 19:47 ` David Ripton
2010-09-27 6:42 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 02/12] gitweb: git_get_heads_list accepts an optional list of refs Giuseppe Bilotta
2010-09-26 17:27 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 03/12] gitweb: separate heads and remotes lists Giuseppe Bilotta
2010-09-26 17:39 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 04/12] gitweb: nagivation menu for tags, heads and remotes Giuseppe Bilotta
2010-09-26 17:52 ` Jakub Narebski [this message]
2010-09-27 6:48 ` Giuseppe Bilotta
2010-09-27 8:30 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 05/12] gitweb: use fullname as hash_base in heads link Giuseppe Bilotta
2010-09-26 17:57 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 06/12] gitweb: allow extra text after action in page header Giuseppe Bilotta
2010-09-26 18:11 ` Jakub Narebski
2010-09-27 6:56 ` Giuseppe Bilotta
2010-09-27 7:42 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 07/12] gitweb: remotes view for a single remote Giuseppe Bilotta
2010-09-26 20:55 ` Jakub Narebski
2010-09-27 7:11 ` Giuseppe Bilotta
2010-09-27 7:53 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 08/12] gitweb: auxiliary function to group data Giuseppe Bilotta
2010-09-26 21:47 ` Jakub Narebski
2010-09-27 7:26 ` Giuseppe Bilotta
2010-09-27 8:12 ` Jakub Narebski
2010-09-27 19:17 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 09/12] gitweb: group styling Giuseppe Bilotta
2010-09-26 22:10 ` Jakub Narebski
2010-09-27 7:27 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 10/12] gitweb: git_repo_url() routine Giuseppe Bilotta
2010-09-26 22:34 ` Jakub Narebski
2010-09-27 7:29 ` Giuseppe Bilotta
2010-09-24 16:02 ` [PATCHv5 11/12] gitweb: use git_repo_url() in summary Giuseppe Bilotta
2010-09-26 22:36 ` Jakub Narebski
2010-09-24 16:02 ` [PATCHv5 12/12] gitweb: gather more remote data Giuseppe Bilotta
2010-09-27 15:47 ` Jakub Narebski
2010-10-23 16:17 ` Giuseppe Bilotta
2010-09-26 18:18 ` [PATCHv5 00/12] gitweb: remote_heads feature Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009261952.07803.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).