From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Yaroslav Halchenko <debian@onerussian.com>, git@vger.kernel.org
Subject: Re: wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log)
Date: Fri, 20 Aug 2010 14:06:19 +0530 [thread overview]
Message-ID: <20100820083614.GD12794@kytes> (raw)
In-Reply-To: <20100820081641.GA32127@burratino>
Hi Jonathan,
Jonathan Nieder writes:
> Ramkumar Ramachandra wrote:
>
> > fmt-merge-msg: Make the number of log entries in shortlog configurable
> >
> > Introduce a new configuration option called merge.logLimit to limit
> > the number of log entries displayed in the shortlog of a merge commit
> > configurable. Set the default value to 20.
>
> Neat. Sign-off?
Oops. I forgot about the new policy: when a patch isn't ready for
inclusion, I must say that explicitly and sign off so others can base
their work on my patch, right?
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> > +++ b/builtin/fmt-merge-msg.c
> > @@ -22,6 +23,8 @@ static int fmt_merge_msg_config(const char *key, const char *value, void *cb)
> > }
> > if (!found_merge_log && !strcmp("merge.summary", key))
> > merge_summary = git_config_bool(key, value);
> > + if (!strcmp("merge.logLimit", key))
> > + log_limit = git_config_int(key, value);
>
> Maybe something like the following would be good on top (or maybe not;
> you decide).
Looks good- since you're interested in this too, I'll include your
patch, test it and post a series to the list.
Thanks.
-- Ram
next prev parent reply other threads:[~2010-08-20 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 2:01 wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log) Yaroslav Halchenko
2010-08-20 6:47 ` Ramkumar Ramachandra
2010-08-20 8:16 ` Jonathan Nieder
2010-08-20 8:36 ` Ramkumar Ramachandra [this message]
2010-08-20 9:10 ` Johannes Sixt
2010-08-20 9:19 ` Ramkumar Ramachandra
2010-08-20 9:29 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820083614.GD12794@kytes \
--to=artagnon@gmail.com \
--cc=debian@onerussian.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).