git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Magnus Bäck" <magnus.back@sonyericsson.com>
To: git@vger.kernel.org
Subject: Status of conflicted files resolved with rerere
Date: Thu, 12 Aug 2010 23:28:28 +0200	[thread overview]
Message-ID: <20100812212828.GA17825@jpl.local> (raw)

I played around with git rerere today and was surprised by the results.
When a conflict has been resolved automatically by rerere, the file
isn't added to the index like other files are where Git just used one of
the regular merge resolution algorithms. What's worse, if git mergetool
is invoked -- which is what I normally do when git merge needs help --
it has no idea that the file actually has been merged already, and
launches the merge tool with the three files involved in the merge. If
the user hasn't been paying attention to each line of the git merge
output (stating the files who were automatically resolved) it's easy to
trash rerere's work.

Would it make sense for git merge to add rerere'd files (where all hunks
were recognized and resolved) to the index automatically? That would
make it possible for the user to run git mergetool without reading every
single line of output from previous commands just to figure out which
files should be added to the index straight off and which files require
merging.

For users resolving conflicts by editing the file and fiddling with the
<<<<<<<<< marks etc such a change wouldn't make that big difference, but
for mergetool users it seems like a quite useful improvement. Or is
there something I'm failing to grasp here? This is on Git 1.7.0.3 by the
way.

-- 
Magnus Bäck                      Opinions are my own and do not necessarily
SW Configuration Manager         represent the ones of my employer, etc.
Sony Ericsson

             reply	other threads:[~2010-08-12 21:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 21:28 Magnus Bäck [this message]
2010-08-12 21:36 ` Status of conflicted files resolved with rerere Avery Pennarun
2010-08-13 17:19   ` Jay Soffian
2010-08-15  2:24   ` David Aguilar
2010-08-15  6:59     ` Junio C Hamano
2010-08-15 16:00       ` Magnus Bäck
2010-08-17  9:22       ` [PATCH] mergetool: Skip autoresolved paths David Aguilar
2010-08-19 10:02         ` Thomas Rast
2010-08-20  3:52           ` David Aguilar
2010-08-20  9:57             ` Charles Bailey
2010-08-20 10:09               ` Jonathan Nieder
2010-08-20 11:17             ` [PATCH] mergetool: Remove explicit references to /dev/tty Charles Bailey
2010-08-20 12:27               ` Jonathan Nieder
2010-08-20 13:50                 ` Charles Bailey
2010-08-20 14:19                   ` Jonathan Nieder
2010-08-20 15:25                 ` [PATCH v2] " Charles Bailey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100812212828.GA17825@jpl.local \
    --to=magnus.back@sonyericsson.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).