From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jens.lehmann@web.de, jherland@gmail.com
Subject: Re: Re: [PATCH v3 4/4] implement automatic fast-forward merge for submodules
Date: Wed, 7 Jul 2010 19:11:09 +0200 [thread overview]
Message-ID: <20100707171059.GA44073@book.hvoigt.net> (raw)
In-Reply-To: <7vwrt7w7qq.fsf@alter.siamese.dyndns.org>
On Wed, Jul 07, 2010 at 09:56:45AM -0700, Junio C Hamano wrote:
> Heiko Voigt <hvoigt@hvoigt.net> writes:
>
> > diff --git a/submodule.c b/submodule.c
> > index 61cb6e2..9bc4b80 100644
> > --- a/submodule.c
> > +++ b/submodule.c
> > @@ -6,6 +6,7 @@
> > #include "revision.h"
> > #include "run-command.h"
> > #include "diffcore.h"
> > +#include "refs.h"
> >
> > static int add_submodule_odb(const char *path)
> > {
> > @@ -218,3 +219,164 @@ unsigned is_submodule_modified(const char *path, int ignore_untracked)
> > ...
> > + while ((commit = get_revision(&revs)) != NULL) {
> > + struct object *o = &(commit->object);
> > + if (in_merge_bases(b, &commit, 1)) {
> > + add_object_array(o, NULL, &merges);
> > + }
>
> Unnecessary braces around a single statement. I've fixed some other style
> violations to this file while replacing the topic branch.
True, that must be a leftover from development. I will check that out
once you pushed the new pu.
> > ...
> > +static void print_commit(struct commit *commit)
> > +{
> > + struct strbuf sb = STRBUF_INIT;
> > + struct pretty_print_context ctx = {0};
> > + ctx.date_mode = DATE_NORMAL;
> > + format_commit_message(commit, " %h: %m %s", &sb, &ctx);
> > + fprintf(stderr, "%s\n", sb.buf);
> > +}
>
> strbuf_release(&sb)???
Definitely, thanks for catching that.
cheers Heiko
prev parent reply other threads:[~2010-07-07 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 13:39 [PATCH v3 0/4] implement automatic submodule merge strategy when possible Heiko Voigt
2010-07-07 13:39 ` [PATCH v3 1/4] add missing && to submodule-merge testcase Heiko Voigt
2010-07-07 13:39 ` [PATCH v3 2/4] teach ref iteration module about submodules Heiko Voigt
2010-07-07 13:39 ` [PATCH v3 3/4] setup_revisions(): allow walking history in a submodule Heiko Voigt
2010-07-07 13:39 ` [PATCH v3 4/4] implement automatic fast-forward merge for submodules Heiko Voigt
2010-07-07 16:56 ` Junio C Hamano
2010-07-07 17:11 ` Heiko Voigt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707171059.GA44073@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jens.lehmann@web.de \
--cc=jherland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).