From: Jonathan Nieder <jrnieder@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org, srabbelier@gmail.com, gitster@pobox.com
Subject: Re: [PATCH] string_list: Add STRING_LIST_INIT macro and make use of it.
Date: Fri, 2 Jul 2010 14:30:02 -0500 [thread overview]
Message-ID: <20100702193002.GB6585@burratino> (raw)
In-Reply-To: <bcb1b64b5db55dd11a398da3cf2c95145852ddfb.1278097858.git.tfransosi@gmail.com>
Thiago Farina wrote:
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Um, I am not so fond of this one.
The argument to STRING_LIST_INIT is hard to interpret without
familiarity. What did you think of Peter’s suggestion to use an a
different macro for the strdup_strings case? Something like
STRING_LIST_INIT_DUP_ON_APPEND, but perhaps shorter.
It would also be nice to update
Documentation/technical/api-string-list.txt with whatever you choose.
That said, I do like the goal of making it easier to reorganize
struct string_list later if needed.
next prev parent reply other threads:[~2010-07-02 19:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 22:34 [PATCH] string-list.h: Add STRING_LIST_INIT macro and make use of it Thiago Farina
2010-06-26 22:53 ` Sverre Rabbelier
2010-06-26 23:04 ` Jonathan Nieder
2010-06-26 23:44 ` Thiago Farina
2010-06-26 23:40 ` Thiago Farina
2010-06-26 23:47 ` Thiago Farina
2010-06-27 16:44 ` Junio C Hamano
2010-06-28 8:29 ` Alex Riesen
2010-06-29 5:43 ` Junio C Hamano
2010-06-29 8:15 ` Peter Kjellerstedt
2010-06-29 8:33 ` Alex Riesen
2010-07-02 19:15 ` [PATCH] string_list: " Thiago Farina
2010-07-02 19:30 ` Jonathan Nieder [this message]
2010-07-02 19:47 ` Thiago Farina
2010-07-02 20:22 ` Jonathan Nieder
2010-07-04 19:46 ` Thiago Farina
2010-07-07 15:19 ` Jonathan Nieder
2010-07-07 16:55 ` Junio C Hamano
2010-07-10 5:01 ` Thiago Farina
2010-07-10 22:41 ` Jonathan Nieder
2010-08-19 13:28 ` Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702193002.GB6585@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).