From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: git@vger.kernel.org, David Michael Barr <david.barr@cordelta.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Daniel Shahaf <d.s@daniel.shahaf.name>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 4/9] Add treap implementation
Date: Thu, 24 Jun 2010 14:22:34 -0500 [thread overview]
Message-ID: <20100624192234.GC1848@burratino> (raw)
In-Reply-To: <AANLkTinYmKl4M10l3u5V7deleqSzr7iJDqf7X6ghtwRM@mail.gmail.com>
Ramkumar Ramachandra wrote:
> David is currently working on
> a Java implementation of a immutable ternary treap and will
> re-implement it as C macros. See the ternary-treap branch.
I assume his blog post from a week or so ago[1] is relevant.
The trie-based version should be interesting but less generic (which
is fine, since we only have two users and both use string keys).
>> $(VCSSVN_OBJS): \
>> - vcs-svn/obj_pool.h
>> + vcs-svn/obj_pool.h vcs-svn/trp.h
>
> Interesting how you've shown this in every patch :)
It would have been less messy to use
$(VCSSVN_OBJS): \
vcs-svn/obj_pool.h \
vcs-svn/trp.h \
... \
or
$(VCSSVN_OBJS): vcs-svn/obj_pool.h
$(VCSSVN_OBJS): vcs-svn/trp.h
...
I just can’t bring myself to care much. :)
> > +/*
> > + * Fibonacci hash function.
> > + * The multiplier is the nearest prime to (2^32 times (√5 - 1)/2).
> > + * See Knuth §6.4: volume 3, 3rd ed, p518.
> > + */
>
> Um, is it alright to put non-ascii characters in a file containing
> code?
Yes, UTF-8 is sometimes used in comments for people’s names. See
builtin/branch.c, for example.
> The documentation is good, but I don't see it merged into the tree.
> Perhaps send a patch to David?
Yes. I should send some other patches, too, to minimize the delta.
> Also, you might want to include the
> technical explanation for using treaps from the commit message here?
Good idea, thanks!
Jonathan
[1] http://barrbrain.github.com/2010/06/19/relocatable-immutable-randomised-ternary-search-tree-part-2.html
next prev parent reply other threads:[~2010-06-24 19:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 10:50 [PATCH/RFC v2 0/9] Subversion dump parsing library Jonathan Nieder
2010-06-24 10:51 ` [PATCH 1/9] Export parse_date_basic() to convert a date string to timestamp Jonathan Nieder
2010-06-24 18:32 ` Ramkumar Ramachandra
2010-06-24 10:52 ` [PATCH 2/9] Introduce vcs-svn lib Jonathan Nieder
2010-06-24 20:27 ` Ramkumar Ramachandra
2010-06-24 10:53 ` [PATCH 3/9] Add memory pool library Jonathan Nieder
2010-06-24 18:43 ` Ramkumar Ramachandra
2010-06-24 18:55 ` Jonathan Nieder
2010-06-24 19:37 ` Ramkumar Ramachandra
2010-06-24 20:06 ` Jonathan Nieder
2010-06-24 20:20 ` Ramkumar Ramachandra
2010-06-24 10:57 ` [PATCH 4/9] Add treap implementation Jonathan Nieder
2010-06-24 19:08 ` Ramkumar Ramachandra
2010-06-24 19:22 ` Jonathan Nieder [this message]
2010-06-24 10:58 ` [PATCH 5/9] Add string-specific memory pool Jonathan Nieder
2010-06-24 19:19 ` Ramkumar Ramachandra
2010-06-24 11:01 ` [PATCH 6/9] Add stream helper library Jonathan Nieder
2010-06-24 21:23 ` Ramkumar Ramachandra
2010-06-24 21:29 ` Jonathan Nieder
2010-06-24 11:02 ` [PATCH 7/9] Add infrastructure to write revisions in fast-export format Jonathan Nieder
2010-06-24 19:29 ` Ramkumar Ramachandra
2010-06-24 19:36 ` Jonathan Nieder
2010-06-24 19:49 ` Jonathan Nieder
2010-06-24 21:14 ` Ramkumar Ramachandra
2010-06-24 11:03 ` [PATCH 8/9] Add SVN dump parser Jonathan Nieder
2010-06-24 20:33 ` Ramkumar Ramachandra
2010-06-24 11:07 ` [PATCH 9/9] Add a sample user for the svndump library Jonathan Nieder
2010-06-24 20:17 ` Ramkumar Ramachandra
2010-06-24 20:30 ` Jonathan Nieder
2010-06-24 20:42 ` Ramkumar Ramachandra
2010-06-24 20:52 ` Jonathan Nieder
2010-06-30 2:09 ` Sam Vilain
2010-06-24 13:06 ` [PATCH/RFC v2 0/9] Subversion dump parsing library Ramkumar Ramachandra
2010-06-24 18:24 ` Jonathan Nieder
2010-06-24 21:26 ` Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2010-07-15 16:22 [PATCH 0/8] Resurrect rr/svn-export Ramkumar Ramachandra
2010-07-16 10:13 ` Jonathan Nieder
2010-07-16 10:23 ` [PATCH 4/9] Add treap implementation Jonathan Nieder
2010-07-16 18:26 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624192234.GC1848@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).