git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	David Michael Barr <david.barr@cordelta.com>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/6] Another attempt to get the SVN exporter merged
Date: Sat, 12 Jun 2010 01:26:13 -0500	[thread overview]
Message-ID: <20100612062613.GA2549@burratino> (raw)
In-Reply-To: <1276175389-6185-1-git-send-email-artagnon@gmail.com>

Hi Ram,

Ramkumar Ramachandra wrote:

> It certainly looks like I'll never give up trying to get this series
> merged- this is my third attempt

First of all, thanks for your work on this and sorry to take so long
to respond[1].

> I still haven't been able to get rid
> of the compiler warnings about unused functions

Will reply to the relevant patch.  Since it’s not so bad to fix, I don’t
think that should hold up queueing the series in pu.

> it looks like
> this series won't graduate to `master` before that happens- I'd
> appreciate pointers on how to do this.

Instead, I suspect the main missing ingredient is a caller.  The
series builds up some library infrastructure with no new feature to
exercise it, which makes it a good time to get feedback but not a good
time to merge.

Of course, we could easily add a feature to exercise it: David’s
svn-fe tool is IMO quite useful on its own (regardless of how the code
will be used later by remote-svn).

I don’t think that is so important for the remote-svn project.  In
other words, I hope some other reviewers show up, but if that doesn’t
happen, I would suggest submitting again for inclusion once the
remote-svn command with import capability is functional.

I planned to write a series adding svn-fe to contrib/ and then the
computer died.  If someone else doesn’t do it first, hopefully I can
try again this weekend.

> Major change since last time: Removed dependency on mmap for
> portability reasons.

Sad but perhaps necessary.  I guess this also opens the possibility of
later making the save operation atomic with the fsync() + rename()
trick.

Regards,
Jonathan

[1] My excuse: laptop died.  My new setup is finally in place and
working well but this Monday I will be on vacation in a land of poor
connectivity --- agh.

  parent reply	other threads:[~2010-06-12  6:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-10 13:09 [PATCH 0/6] Another attempt to get the SVN exporter merged Ramkumar Ramachandra
2010-06-10 13:09 ` [PATCH 1/6] Add memory pool library Ramkumar Ramachandra
2010-06-12  6:42   ` Jonathan Nieder
2010-06-14 14:25     ` Ramkumar Ramachandra
2010-06-14 14:44       ` Andreas Ericsson
2010-06-10 13:09 ` [PATCH 2/6] Add cpp macro implementation of treaps Ramkumar Ramachandra
2010-06-10 13:09 ` [PATCH 3/6] Add library for string-specific memory pool Ramkumar Ramachandra
2010-06-11 19:33   ` Junio C Hamano
2010-06-14  9:26     ` Ramkumar Ramachandra
2010-06-14 13:36       ` Junio C Hamano
2010-06-14 13:49         ` Ramkumar Ramachandra
2010-06-14 14:45           ` David Michael Barr
2010-06-10 13:09 ` [PATCH 4/6] Add stream helper library Ramkumar Ramachandra
2010-06-10 13:09 ` [PATCH 5/6] Add infrastructure to write revisions in fast-export format Ramkumar Ramachandra
2010-06-10 13:09 ` [PATCH 6/6] Add SVN dump parser Ramkumar Ramachandra
2010-06-10 15:24   ` Ramkumar Ramachandra
     [not found] ` <AANLkTin3iQK7YHGgjxlAjtchu3ZpntjQHK7LkfxxJj6q@mail.gmail.com>
2010-06-10 13:22   ` [PATCH 0/6] Another attempt to get the SVN exporter merged Ramkumar Ramachandra
2010-06-12  6:26 ` Jonathan Nieder [this message]
2010-06-14 14:41   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100612062613.GA2549@burratino \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=david.barr@cordelta.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).