From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
kusmabite@gmail.com, Erik Faye-Lund <kusmabite@googlemail.com>,
Andreas Ericsson <ae@op5.se>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: Misterious warning about file system boundaries [It's a bug, not a mystery.]
Date: Thu, 10 Jun 2010 07:02:58 -0400 [thread overview]
Message-ID: <20100610110258.GA17290@coredump.intra.peff.net> (raw)
In-Reply-To: <AANLkTikle0gxLvKkhr-APkt_6QCB0hVu7bIGm0sRcjVK@mail.gmail.com>
On Thu, Jun 10, 2010 at 10:52:40AM +0000, Ævar Arnfjörð Bjarmason wrote:
> On Thu, Jun 10, 2010 at 10:36, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> > I guess we need --I-really-mean-it-refresh.
> >
> > In fact, not even after recompiling with USE_STDEV=y that
> > --really-refresh helps which stomps me.But what do I know.
>
> The real problem here is the assumption in 52b98a7 that stat's st_dev
> will stay the same for a given device, clearly that's not the case on
> Linux if you reboot your machine.
>
> Is there some way of working around that?
We could simply drop the warning. The real point of the original patch
was to stop cross-device traversal in setup_git_directory, which doesn't
care about crossing reboots. I believe the index check and warning are
just there as an early suggestion. When you actually fail to cross the
device boundary looking for .git in the future, it will complain and
mention GIT_DISCOVERY_ACROSS_FILESYSTEM then.
Since the early-warning suggestion is generating false positives, and I
don't think there is a portable and reliable way around it, dropping it
makes sense to me.
-Peff
next prev parent reply other threads:[~2010-06-10 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 20:21 Misterious warning about file system boundaries Michael J Gruber
2010-06-10 8:03 ` Andreas Ericsson
2010-06-10 9:05 ` Misterious warning about file system boundaries [It's a bug, not a mystery.] Michael J Gruber
2010-06-10 9:39 ` Erik Faye-Lund
2010-06-10 10:36 ` Michael J Gruber
2010-06-10 10:52 ` Ævar Arnfjörð Bjarmason
2010-06-10 11:02 ` Jeff King [this message]
2010-06-10 14:53 ` Junio C Hamano
2010-06-12 4:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610110258.GA17290@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=ae@op5.se \
--cc=avarab@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=kusmabite@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).