From: Jonathan Nieder <jrnieder@gmail.com>
To: Robert Buck <buck.robert.j@gmail.com>
Cc: "git@vger.kernel.org List" <git@vger.kernel.org>,
Chris Packham <judge.packham@gmail.com>
Subject: Re: [remote rejected] master -> master (n/a (unpacker error))
Date: Wed, 12 May 2010 19:52:19 -0500 [thread overview]
Message-ID: <20100513005218.GA20655@progeny.tock> (raw)
In-Reply-To: <AANLkTinV2U6Lbbl0N7jVAESEi0mZQ_D3slMEYa68vRT4@mail.gmail.com>
Hi Robert,
Robert Buck wrote:
> error: unable to create temporary sha1 filename ./objects/e6: File exists
Yeah, this error message is not so great.
The relevant code is in sha1_file.c.
fd = create_tmpfile(tmpfile, sizeof(tmpfile), filename);
while (fd < 0 && errno == EMFILE && unuse_one_window(packed_git, -1))
fd = create_tmpfile(tmpfile, sizeof(tmpfile), filename);
if (fd < 0) {
if (errno == EACCES)
return error("insufficient permission for adding an object to repository database %s\n", get_object_directory());
else
return error("unable to create temporary sha1 filename %s: %s\n", tmpfile, strerror(errno));
}
create_tmpfile() creates a filename of the form
./objects/e6/tmp_obj_<random letters> and tries to open that file.
The random value is based on the current time and the process ID of
the current process. If the file exists, it tries again with another
collection of random letters, up to 16384 times.
In your case, all 16384 trials yielded the same result: file already
existed. As a workaround, I’d suggest
rm -f .git/objects/??/tmp_obj_*
but it might be nice to get a listing with "ls -lR .git/objects" first
for post-mortem analysis.
And presumably the directory filled with temporary files that could
not be renamed to a proper name for some reason. Probably a permissions
problem, as Chris suggested.
-- 8< --
Subject: write_loose_object(): improve error message for some mkstemp failures
If the .git/objects/ab/ directory fills up with tmp_obj_ files, the
result is a cryptic error:
error: unable to create temporary sha1 filename ./objects/e6: File exists
Replace it with the slightly less cryptic
error: cannot write temporary file under ./objects/e6: all the good filenames are taken
Reported-by: Robert Buck <buck.robert.j@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
> As an aside, where the heck is the git bug tracker?
Here is an answer from the last time it came up[1]:
See http://thread.gmane.org/gmane.comp.version-control.git/136500
Short answer: the usual method is to report bugs to the list,
preferably with a patch for t/ or even better, a fix.
> I've searched, and
> searched, and ... All I found is a Debian tracking system, which
> appears to have no full text search capabilities.
http://merkel.debian.org/~don/cgi/search.cgi
http://www.google.com/search?q=site:bugs.debian.org+"Package:+git"+"file+exists"
Thoughts? Improvements?
Jonathan
[1] http://thread.gmane.org/gmane.linux.debian.devel.bugs.general/680778/focus=141598
sha1_file.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 28c056e..a2aa301 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2288,6 +2288,10 @@ static int write_loose_object(const unsigned char *sha1, char *hdr, int hdrlen,
if (fd < 0) {
if (errno == EACCES)
return error("insufficient permission for adding an object to repository database %s\n", get_object_directory());
+ else if (errno == EEXIST)
+ return error("cannot write temporary file under %s: "
+ "all the good filenames are taken\n",
+ tmpfile);
else
return error("unable to create temporary sha1 filename %s: %s\n", tmpfile, strerror(errno));
}
--
1.7.1
next prev parent reply other threads:[~2010-05-13 0:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 19:45 [remote rejected] master -> master (n/a (unpacker error)) Robert Buck
2010-05-13 0:06 ` Chris Packham
2010-05-13 0:52 ` Jonathan Nieder [this message]
2010-05-13 9:30 ` Robert Buck
2010-05-13 12:05 ` Greg Troxel
2010-05-13 13:22 ` Andreas Schwab
2010-05-13 13:56 ` Jonathan Nieder
2015-11-27 21:37 ` DavidLeeCrites
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513005218.GA20655@progeny.tock \
--to=jrnieder@gmail.com \
--cc=buck.robert.j@gmail.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).