From: "Gary V. Vaughan" <git@mlists.thewrittenword.com>
To: Tor Arntsen <tor@spacetec.no>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/5] Dangling commas in enum is not portable (resend)
Date: Sun, 25 Apr 2010 11:03:06 -0500 (CDT) [thread overview]
Message-ID: <20100425152449.GB27695@thor.il.thewrittenword.com> (raw)
In-Reply-To: <l2od2d39d861004250612g9ac6c7b4qdaa8ce0f973846e7@mail.gmail.com>
On Sun, Apr 25, 2010 at 03:12:37PM +0200, Tor Arntsen wrote:
> On Sun, Apr 25, 2010 at 10:35, Gary V. Vaughan
> <git@mlists.thewrittenword.com> wrote:
>
> > I take it back. ?I've been porting this patch forward from our builds
> > of previous releases, and at some point it certainly was necessary
> > (otherwise I wouldn't have written the patch)... and yet, all of our
> > platforms are now able to compile a minimal test program in C.
> > [[...]]
> > It's notable that aCC (the HP C++ compiler) and CC (the SunOS C++
> > compiler) both issue a warning on dangling enum commas, but even they
> > still compile successfully.
>
> The SGI MIPS Compiler v6.2 on IRIX 6.2 compiles, but with a warning.
> Later MIPSPro 7.2 and 7.4 versions (on 6.5) are OK (silent)
> Unfortunately IBM VisualAge C 5.0 (I have 5.0.2) on AIX 5.1 fails to
> compile with a trailing comma.
> IBM XLC V10.1 (I have one on AIX 6.1) is OK (silent)
> Native compiler on Tru64 V5.1 is OK (silent)
>
> So, from the boxes I have access to the IBM XLC V5 version is the one
> which has a problem.
I'd be happy to resurrect this patch and resubmit against the latest
git release.
Cheers,
--
Gary V. Vaughan (gary@thewrittenword.com)
prev parent reply other threads:[~2010-04-25 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 16:32 [PATCH 3/5] Dangling commas in enum is not portable (resend) Gary V. Vaughan
2010-03-12 9:18 ` Felipe Contreras
2010-04-25 8:35 ` Gary V. Vaughan
2010-04-25 13:12 ` Tor Arntsen
2010-04-25 16:03 ` Gary V. Vaughan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425152449.GB27695@thor.il.thewrittenword.com \
--to=git@mlists.thewrittenword.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=tor@spacetec.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).