From: Johannes Sixt <j6t@kdbg.org>
To: git@vger.kernel.org
Subject: [PATCH/RFC 0/3] git rerere unresolve file
Date: Sat, 21 Nov 2009 19:58:40 +0100 [thread overview]
Message-ID: <200911211958.40872.j6t@kdbg.org> (raw)
When you commit an incorrect conflict resolution, git rerere gets in the way:
rerere clear only clears cache entries of not yet resolved conflicts. But
there is no other way to remove an incorrect resolution short of purging the
whole rr-cache.
This series implements 'git rerere unresolve' that removes a recorded
resolution.
This is RFC for two reasons:
- It changes the contents of MERGE_RR in a way that *may* interfer in unwanted
ways with older versions that do not understand unresolve.
- rerere unresolve also restores the conflict regions. I'm not sure whether
this is good because there is 'git checkout --conflict=merge file' that does
it in a better way. See the commit message of patch 3.
If rerere unresolve does *not* restore conflict regions (and record the result
as preimage right away) we are facing a problem: When the resolution is
committed, the postimage has differences from the preimage that are not
related to the conflict. This may inhibit reusing the resolution later when
the file has new changes.
Johannes Sixt (3):
rerere: keep a list of resolved files in MERGE_RR
rerere: make recording of the preimage reusable
git rerere unresolve file...
Documentation/git-rerere.txt | 10 +++-
builtin-rerere.c | 13 +++-
rerere.c | 153 ++++++++++++++++++++++++++++++++++-------
rerere.h | 4 +-
4 files changed, 148 insertions(+), 32 deletions(-)
next reply other threads:[~2009-11-21 20:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 18:58 Johannes Sixt [this message]
2009-11-21 19:00 ` [PATCH/RFC 1/3] rerere: keep a list of resolved files in MERGE_RR Johannes Sixt
2009-11-21 19:01 ` [PATCH/RFC 2/3] rerere: make recording of the preimage reusable Johannes Sixt
2009-11-21 19:02 ` [PATCH/RFC 3/3] git rerere unresolve file Johannes Sixt
2009-11-22 2:53 ` [PATCH/RFC 0/3] " Junio C Hamano
2009-11-22 14:19 ` Johannes Sixt
2009-11-24 23:40 ` Nanako Shiraishi
2009-12-29 21:42 ` [PATCH 0/9] Undoing conflict resolution Junio C Hamano
2009-12-29 21:42 ` [PATCH 1/9] builtin-merge.c: use standard active_cache macros Junio C Hamano
2009-12-29 21:42 ` [PATCH 2/9] resolve-undo: record resolved conflicts in a new index extension section Junio C Hamano
2009-12-29 21:42 ` [PATCH 3/9] resolve-undo: basic tests Junio C Hamano
2009-12-29 21:42 ` [PATCH 4/9] resolve-undo: allow plumbing to clear the information Junio C Hamano
2009-12-29 21:42 ` [PATCH 5/9] resolve-undo: "checkout -m path" uses resolve-undo information Junio C Hamano
2009-12-29 21:42 ` [PATCH 6/9] resolve-undo: teach "update-index --unresolve" to use resolve-undo info Junio C Hamano
2009-12-29 21:42 ` [PATCH 7/9] rerere: remove silly 1024-byte line limit Junio C Hamano
2009-12-29 21:42 ` [PATCH 8/9] rerere: refactor rerere logic to make it independent from I/O Junio C Hamano
2009-12-29 21:42 ` [PATCH 9/9] rerere forget path: forget recorded resolution Junio C Hamano
2010-01-05 21:25 ` Johannes Sixt
2010-01-06 1:06 ` Junio C Hamano
2010-01-06 8:55 ` Johannes Sixt
2010-01-06 16:58 ` Junio C Hamano
2010-01-06 21:59 ` Junio C Hamano
2010-01-08 21:55 ` Johannes Sixt
2010-01-08 23:20 ` Junio C Hamano
2010-01-11 1:58 ` Junio C Hamano
2010-01-11 19:22 ` Johannes Sixt
2010-01-11 20:05 ` Junio C Hamano
2010-01-11 21:05 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911211958.40872.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).