From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Alf Kristian St??yle <alf.kristian@gmail.com>, git@vger.kernel.org
Subject: Re: git stash list shows timestamp in stead of "stash number", when setting date = local for log in config
Date: Fri, 25 Sep 2009 15:29:20 -0700 [thread overview]
Message-ID: <20090925222920.GZ14660@spearce.org> (raw)
In-Reply-To: <20090924070121.GD24486@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> On Tue, Sep 15, 2009 at 04:56:41PM +0200, Alf Kristian St??yle wrote:
> > When doing a "git stash list" I get this strange stash record:
> > stash@{Tue Sep 15 16:28:12 2009}: WIP on master: 2262276 ...
> >
> > I have a global config setting on log:
> >
> > [log]
> > date = local
> >
> > If setting the date config to default or removing the setting, the
> > stash record looks correct:
> > stash@{0}: WIP on master: 2262276 ...
>
> The patch below implements the former. The only downside I can think of
> is if somebody is relying on "log.date" to set the output format for
> reflogs, because they really like the date version better. In that case,
> I think we should wait for them to complain (which I doubt will happen),
> and then add a log.reflogDates config option to appease them.
>
> Shawn, reflogs are your thing. Any comments?
I agree. I doubt anyone is relying on log.date to reformat the
output of `git reflog show` or `git stash list`, so this is probably
a reasonable change to make. Even if they were trying to use that,
its a bug.
Care to wrap this up in a patch?
--
Shawn.
next prev parent reply other threads:[~2009-09-25 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 14:56 git stash list shows timestamp in stead of "stash number", when setting date = local for log in config Alf Kristian Støyle
2009-09-24 7:01 ` Jeff King
2009-09-25 22:29 ` Shawn O. Pearce [this message]
2009-09-27 7:50 ` [PATCH] improve reflog date/number heuristic Jeff King
2009-09-27 8:25 ` git stash list shows timestamp in stead of "stash number", when setting date = local for log in config Alf Kristian Støyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925222920.GZ14660@spearce.org \
--to=spearce@spearce.org \
--cc=alf.kristian@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).