* run_hook: why special check for uncaught signal?
@ 2009-06-30 20:31 Johannes Sixt
2009-07-01 9:57 ` Miklos Vajna
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Sixt @ 2009-06-30 20:31 UTC (permalink / raw
To: git, Miklos Vajna
Function run_hook (in run-command.c) has this check:
ret = finish_command(&hook);
if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
warning("%s exited due to uncaught signal", argv[0]);
return ret;
The lines were moved to this location by ae98a008 (Move run_hook() from
builtin-commit.c into run-command.c (libgit), 2009-01-16). Before this
commit, the check existed in builtin-gc.c. It was introduced by bde30540
(git-gc --auto: add pre-auto-gc hook, 2008-04-09).
Why is this check necessary?
I'm asking because I'm working on a modification that would remove
ERR_RUN_COMMAND_WAITPID_SIGNAL.
-- Hannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: run_hook: why special check for uncaught signal?
2009-06-30 20:31 run_hook: why special check for uncaught signal? Johannes Sixt
@ 2009-07-01 9:57 ` Miklos Vajna
0 siblings, 0 replies; 2+ messages in thread
From: Miklos Vajna @ 2009-07-01 9:57 UTC (permalink / raw
To: Johannes Sixt; +Cc: git
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On Tue, Jun 30, 2009 at 10:31:45PM +0200, Johannes Sixt <j6t@kdbg.org> wrote:
> Function run_hook (in run-command.c) has this check:
>
> ret = finish_command(&hook);
> if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
> warning("%s exited due to uncaught signal", argv[0]);
> return ret;
>
> The lines were moved to this location by ae98a008 (Move run_hook() from
> builtin-commit.c into run-command.c (libgit), 2009-01-16). Before this
> commit, the check existed in builtin-gc.c. It was introduced by bde30540
> (git-gc --auto: add pre-auto-gc hook, 2008-04-09).
>
> Why is this check necessary?
I do not really remember, but I think I wanted to give some error
messages for each return code, and somehow left out
ERR_RUN_COMMAND_WAITPID, ERR_RUN_COMMAND_WAITPID_WRONG_PID and
ERR_RUN_COMMAND_WAITPID_NOEXIT.
> I'm asking because I'm working on a modification that would remove
> ERR_RUN_COMMAND_WAITPID_SIGNAL.
That's fine, I think ideally run_hook() should call warning() for each
case which may be returned. Such functionality is already available in
builtin-receive-pack.c::hook_status() and unpack(), probably it would
make sense to introduce some run_command_strerror() to avoid code
duplication.
Sadly I don't have time to implement this in the near future.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-01 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-30 20:31 run_hook: why special check for uncaught signal? Johannes Sixt
2009-07-01 9:57 ` Miklos Vajna
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).