From: Ingo Molnar <mingo@elte.hu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"roel kluin" <roel.kluin@gmail.com>,
git@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] fread does not return negative on error
Date: Wed, 24 Jun 2009 10:18:19 +0200 [thread overview]
Message-ID: <20090624081819.GA10436@elte.hu> (raw)
In-Reply-To: <7vhby64i8f.fsf@alter.siamese.dyndns.org>
* Junio C Hamano <gitster@pobox.com> wrote:
> René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
>
> > the following patch is for git. I just removed the unneeded check for
> > res == 0 from your version. Does it look OK?
>
> The patch looks good, and both of our in-tree users do error out
> when the returned value is 0 (imap-send.c checks with "<= 0" which
> looks a tad amateurish, though) correctly.
>
> Funny, there is no caller of this function in the original context
> this bug originally found, which I think is linux-2.6/tools/perf
> ;-).
Hehe, yes :-)
Background: when creating tools/perf/ i cherry-picked all the nice
Git libraries into tools/perf/util/, to give a standard environment
for all tooling things that might come up in the future.
Some of those are not used yet but it looked more logical to pick up
whole pieces - some already gained uses. For example config.c is not
truly used yet, but very much expected to have a role in the future.
( The only invasive thing i had to do was the s/git_/perf_/ mass
rename across all the files - having 'git_' in perf looked
quite confusing. )
And our general experience with the Git libraries in
tools/perf/util/* is: we love them!
For example parse-options.c is a striking improvement compared to
getopt.h we used before, and all the other facilities are sane and
straight to the point as well. So in this sense 'perf' is an ...
interesting cross-discipline 'fork' of Git's generic libraries.
The auto-generation of everything out of Documentation/*.txt is
another thing we picked up, and that's very nice too.
One bookeeping issue: i found few explicit credits in those files -
so i noted in the changelog that i took them from Git and i noted
the specific upstream Git sha1 when i copied them. Would be nice to
update each file with names to make credit more explicit:
-rw-rw-r-- 1 mingo mingo 2808 2009-06-23 10:49 abspath.c
-rw-rw-r-- 1 mingo mingo 1447 2009-06-23 10:49 alias.c
-rw-rw-r-- 1 mingo mingo 4660 2009-06-23 10:49 cache.h
-rw-rw-r-- 1 mingo mingo 4817 2009-06-23 10:49 color.c
-rw-rw-r-- 1 mingo mingo 1187 2009-06-23 10:49 color.h
-rw-rw-r-- 1 mingo mingo 19149 2009-06-23 10:49 config.c
-rw-rw-r-- 1 mingo mingo 1041 2009-06-23 10:52 ctype.c
-rw-rw-r-- 1 mingo mingo 256 2009-06-23 10:49 environment.c
-rw-rw-r-- 1 mingo mingo 3262 2009-06-23 10:49 exec_cmd.c
-rw-rw-r-- 1 mingo mingo 496 2009-06-23 10:49 exec_cmd.h
-rw-rw-r-- 1 mingo mingo 8515 2009-06-23 10:49 help.c
-rw-rw-r-- 1 mingo mingo 751 2009-06-23 10:49 help.h
-rw-rw-r-- 1 mingo mingo 2592 2009-06-23 10:49 levenshtein.c
-rw-rw-r-- 1 mingo mingo 201 2009-06-23 10:49 levenshtein.h
-rw-rw-r-- 1 mingo mingo 1909 2009-06-23 10:49 pager.c
-rw-rw-r-- 1 mingo mingo 12454 2009-06-23 10:49 parse-options.c
-rw-rw-r-- 1 mingo mingo 5693 2009-06-23 10:49 parse-options.h
-rw-rw-r-- 1 mingo mingo 7986 2009-06-23 10:49 path.c
-rw-rw-r-- 1 mingo mingo 10442 2009-06-23 10:49 quote.c
-rw-rw-r-- 1 mingo mingo 2667 2009-06-23 10:49 quote.h
-rw-rw-r-- 1 mingo mingo 7966 2009-06-23 10:49 run-command.c
-rw-rw-r-- 1 mingo mingo 2838 2009-06-23 10:49 run-command.h
-rw-rw-r-- 1 mingo mingo 969 2009-06-23 10:49 sigchain.c
-rw-rw-r-- 1 mingo mingo 215 2009-06-23 10:49 sigchain.h
-rw-rw-r-- 1 mingo mingo 7270 2009-06-23 10:49 strbuf.c
-rw-rw-r-- 1 mingo mingo 4995 2009-06-23 10:49 strbuf.h
-rw-rw-r-- 1 mingo mingo 556 2009-06-23 10:52 string.c
-rw-rw-r-- 1 mingo mingo 120 2009-06-23 10:52 string.h
-rw-rw-r-- 1 mingo mingo 13859 2009-06-24 10:01 symbol.c
-rw-rw-r-- 1 mingo mingo 1112 2009-06-23 10:52 symbol.h
-rw-rw-r-- 1 mingo mingo 1690 2009-06-23 10:49 usage.c
-rw-rw-r-- 1 mingo mingo 9878 2009-06-23 10:52 util.h
-rw-rw-r-- 1 mingo mingo 4249 2009-06-23 10:49 wrapper.c
Ingo
next prev parent reply other threads:[~2009-06-24 8:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A3FB09D.9050903@gmail.com>
2009-06-22 15:34 ` [PATCH] tools: fread does not return negative on error Ingo Molnar
2009-06-22 15:47 ` roel kluin
2009-06-22 16:42 ` [PATCH] " René Scharfe
2009-06-23 23:56 ` Junio C Hamano
2009-06-24 8:18 ` Ingo Molnar [this message]
2009-06-24 10:03 ` Johannes Schindelin
2009-06-24 16:15 ` Junio C Hamano
2009-06-24 16:40 ` Johannes Schindelin
2009-06-24 17:59 ` Ingo Molnar
2009-06-24 21:19 ` Alex Riesen
2009-06-24 21:55 ` Junio C Hamano
2009-06-24 10:53 ` Christian Couder
2009-06-24 12:12 ` Ingo Molnar
2009-06-25 18:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624081819.GA10436@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).