From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH] Fix CanonicalTreeParser.back to parse all trees correctly
Date: Fri, 12 Jun 2009 08:08:01 -0700 [thread overview]
Message-ID: <20090612150801.GA17538@spearce.org> (raw)
In-Reply-To: <1244412116-13294-1-git-send-email-spearce@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> The back(int delta) method needs to walk backwards delta entries in
> the tree we are iterating. Unfortunately, despite my attempts to do
> so, there is no reliable way to parse a canonical tree in reverse.
Ping?
Without this patch the NameConflictDirWalk can get into some serious
trouble, trouble which can cause Gerrit Code Review to have its
memory explode to >8 GiB, because NCDW gets stuck in an infinite
loop, forever allocating reachable memory inside of a MergeStrategy.
I've made a private build of this and am running it in production
within day-job employer, but I can't make a release of Gerrit until
I have a stable identifier for this patch.
> .../jgit/treewalk/CanonicalTreeParserTest.java | 78 ++++++++++++++++++-
> .../spearce/jgit/treewalk/CanonicalTreeParser.java | 74 +++++++++---------
> 2 files changed, 110 insertions(+), 42 deletions(-)
--
Shawn.
next prev parent reply other threads:[~2009-06-12 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 22:01 [JGIT PATCH] Fix CanonicalTreeParser.back to parse all trees correctly Shawn O. Pearce
2009-06-12 15:08 ` Shawn O. Pearce [this message]
2009-06-13 8:06 ` Ferry Huberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612150801.GA17538@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).