From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: Refuse to send cover-letter template subject
Date: Tue, 9 Jun 2009 10:19:05 +0200 [thread overview]
Message-ID: <200906091019.11000.trast@student.ethz.ch> (raw)
In-Reply-To: <7v4ouqwa42.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
>
> > Every so often, someone sends out an unedited cover-letter template.
> > Add a simple check to send-email that refuses to send if the subject
> > contains "*** SUBJECT HERE ***", with an option --force to override.
>
> Good ;-). More valuable to detect would be an empty "blurb" section
> (i.e. not "unedited *** BLURB HERE ***" string, but literally, there is
> nothing said in the message other than the shortstat).
Wouldn't that be AI complete? As in, whatever regex (or similar) you
might cook up could probably be matched by *someone's* style of patch
descriptions, and then it suddenly becomes rather hard to tell them
apart.
I was really only trying to prevent the case where the user formatted
several times in a row because he noticed mistakes in the patches, and
forgot to re-edit the cover letter. At least that's how I once sent
out one with a real description but the template subject.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2009-06-09 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 21:34 [PATCH] send-email: Refuse to send cover-letter template subject Thomas Rast
2009-06-08 23:59 ` Junio C Hamano
2009-06-09 8:19 ` Thomas Rast [this message]
2009-06-12 11:48 ` Thomas Rast
2009-06-12 16:06 ` Junio C Hamano
2009-06-09 18:25 ` Markus Heidelberg
2009-06-09 19:00 ` Junio C Hamano
2009-06-09 19:32 ` Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906091019.11000.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).