From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: Request for detailed documentation of git pack protocol Date: Wed, 3 Jun 2009 02:50:00 +0200 Message-ID: <200906030250.01413.jnareb@gmail.com> References: <200905122329.15379.jnareb@gmail.com> <200906022339.08639.jnareb@gmail.com> <20090602232724.GN30527@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Scott Chacon , git@vger.kernel.org To: "Shawn O. Pearce" X-From: git-owner@vger.kernel.org Wed Jun 03 02:50:26 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MBegT-0000az-Ms for gcvg-git-2@gmane.org; Wed, 03 Jun 2009 02:50:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826AbZFCAuK (ORCPT ); Tue, 2 Jun 2009 20:50:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751713AbZFCAuJ (ORCPT ); Tue, 2 Jun 2009 20:50:09 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:57809 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbZFCAuG (ORCPT ); Tue, 2 Jun 2009 20:50:06 -0400 Received: by fg-out-1718.google.com with SMTP id d23so1013589fga.17 for ; Tue, 02 Jun 2009 17:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=uH0EPbQf/miP94qipHsCu9cxopAfZKXu27oWwQzuiNc=; b=sEZ6rhyXp+Vpb+/NSzl2iSfpFtPdtS5yn/V6tRFtddNlQd9F4RrrOEABEVmaw2GPzB u6GP6TpHcfd6YJA4I/o61/v8vm1UYN88xWm4JGu8va2PVyqeiTZ78sqjfGZgJYZNbUKK gmqzqaP3jVPBuQ7qUdP9VaGzVqamu8kCdCIeY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=Zd+Ya3R/3WlSTqCOnnx8nN/mTvIENTYA2aqxShlKbtp+Tz+7MDkfRnGe/XgCVYYacU a0Qht9xkUyGzC4r4nLMiLy7MNW/ssp85iAmN3rIs8IjbW8Lu6O3dLhCV7PBeui5RUicB gQigCtwF0/P7rMon+NBJfCv99QuOJaeaO7TqY= Received: by 10.86.70.3 with SMTP id s3mr515620fga.12.1243990206891; Tue, 02 Jun 2009 17:50:06 -0700 (PDT) Received: from ?192.168.1.13? (abws210.neoplus.adsl.tpnet.pl [83.8.242.210]) by mx.google.com with ESMTPS id 4sm448208fge.8.2009.06.02.17.50.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 02 Jun 2009 17:50:06 -0700 (PDT) User-Agent: KMail/1.9.3 In-Reply-To: <20090602232724.GN30527@spearce.org> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Thank you very much for your comments! On Wed, 3 Jun 2009, Shawn O. Pearce wrote: > Jakub Narebski wrote: >> I see that there is (at least beginnings of) description of git pack >> protocol in section "Transfer Protocols"[1][2] of chapter "7. Internals >> and Plumbing" of "Git Community Book". >> >> [1] http://book.git-scm.com/7_transfer_protocols.html >> [2] http://github.com/schacon/gitbook/blob/master/text/54_Transfer_Protocols/0_Transfer_Protocols.markdown >> >>> ### Fetching Data with Upload Pack ### >>> >>> For the smarter protocols, fetching objects is much more efficient. >>> A socket is opened, either over ssh or over port 9418 (in the case of >>> the git:// protocol), and the linkgit:git-fetch-pack[1] command on >>> the client begins communicating with a forked >>> linkgit:git-upload-pack[1] process on the server. >> >> Is fetching over SSH exactly the same as fetching over git:// protocol? > > Yes. Except git:// starts off by sending "git-receive-pack > 'repo.git'" on the wire using a pkt-line format, while ssh:// sends > that by way of the remote exec support built into the SSH protocol. > IOW, the only way that git:// differs from SSH is by providing the > smallest shim possible to replace that remote exec feature. > >>> Let's look at an example. >>> >>> The client connects and sends the request header. The clone command >>> >>> $ git clone git://myserver.com/project.git >>> >>> produces the following request: >>> >>> 0032git-upload-pack /project.git\\000host=myserver.com\\000 [...] So this mean that when cloning via SSH $ git clone ssh://myserver.com/project.git instead of this first request git would simply invoke [something like]: # ssh myserver.com git-upload-pack project.git isn't it? (I am not sure if it uses "project.git" or "/project.git", and how it does generate full pathname for repository). BTW I wonder why we use stuffing here using "\0" / NUL as separator trick, and whether line has to be terminated with "\0", or can it be terminated with "\n". >> >> There is a question how to organize this information. Should we describe >> pkt-line format upfront, e.g. using ABNF notation from RFC 5234 used in >> RFC documents: >> >> = ( [ LF ] ) / >> = 4HEXDIGIT ; length of >> = "0000" >> >> or something like that? > > Yes. where HEXDIGIT = 0-9 / a-f Well, it should probably be spelled in full. Probably, because I have no experience with using ABNF... and didn't do my research :-) HEXDIGIT = DIGIT / "a" / "b" / "c" / "d" / "e" / "f" DIGIT = "0" / "1" / "2" / "3" / "4" / "5" / "6" / "7" / "8" / "9" (should HEXDIGIT use lowercase a-f, or can it use uppercase A-F?) >> Sidenote: wouldn't it be better to use \0 (\\0 in source) for NUL >> character rather than \000 (\\000 in source) octal representation? > > Most languages today honor '\0' or "\0" as a means of embedding a > NUL into a char type. So \0 seems correct to me. That was more a question to Scott Chacon, sorry. Do Ruby understand "\0", or do you need to spell it "\000"? > >>> The request is processed and turned into a call to git-upload-pack: >>> >>> $ git-upload-pack /path/to/repos/project.git >> >> Is it "git-upload-pack" or "git upload-pack" nowadays? > > Sadly, we still invoke "git-upload-pack" IIRC. So that is why git-upload-pack has to be in $PATH, or is it only because new server can be used with old clients (before git-cmd moving outside $PATH)? > >>> This immediately returns information of the repo: >> >> To be more exact this is information about references (I guess this >> is information about heads only, is it?) > > No, its *all* refs. `git for-each-ref` plus HEAD. You meant probably `git show-ref` plus HEAD, isn't it? `git for-each-ref` has different default output... Still, example should IMHO include at least one tag... > >> , with information about >> server capabilities stuffed in. >> >>> >>> 007c74730d410fcb6603ace96f1dc55ea6196122532d HEAD\\000multi_ack thin-pack side-band side-band-64k ofs-delta shallow no-progress >>> 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug >>> 003d5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/dist >>> 003e7e47fe2bd8d01d481f44d7af0531bd93d3b21c01 refs/heads/local >>> 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master >>> 0000 >>> >>> Each line starts with a four byte line length declaration in hex. The >>> section is terminated by a line length declaration of 0000. >> >> Should we describe here, or in appendix, or in sidenote, or in footnote >> all currently supported client capabilities and server capabilities? > > Yes. > >> * multi_ack (why not multi-ack?) > > Hysterical rasins. ;-) What does multi_ack capability mean? >> * thin-pack Server can send thin packs, i.e. packs which do not contain base elements, if those base elements are available on clients side. Client has thin-pack capability when it understand how to "thicken" them adding required delta bases making them independent. Of course it doesn't make sense for client to use (request) this capability for git-clone. >> * side-band >> * side-band-64k This probably means that server can send, and client understand multiplexed (muxed) progress reports and error info interleaved with the packfile itself. But I don't know what is the difference, whether server can provide side-band-64k without the other (side-band), and whether client has to request only one of those two capabilities. >> * ofs-delta Server can send, and client understand PACKv2 with delta refering to its base by position in pack rather than by SHA-1... do I understand this correctly? >> * shallow Server can send shallow clone (git clone --depth ...). >> * no-progress What that does mean? >> >> Is each line terminated by "\n" or "\0"? > > Actually, its weird... Each line is terminated by a "\n" by > convention only, which is included in the 4 byte length declaration. > After reading a line the client slaps a NUL onto the end at the > position indicated by the length declaration, and processes the > line, skipping the "\n" at the end if it is present, and sliently > accepting the line just fine if the "\n" is missing. This probably should be described... Does git require that each line is terminated by something (e.g. "\n"), or does it not? > > This is why the "\0capability" hack works, the client didn't care > that that first ref doesn't end in an LF. But it stopped where that > "\0" was because it was using a C string style operator. It is a bit pity tat git protocol was not created with extendability (like capabilities) in mind... > >> Is 'flush' line? This is not >> clear from above description. From simple playing with nc (netcat) it >> looks like each line with exception of '0000' is terminated with "\n". > > The only reason we end with "\n" is to make playing with netcat > easier. There isn't a real practical reason in terms of the protocol > for why you need that "\n" in there. > > But. That flush line is magical. A length of "0000" means its a > flush packet, which has no data payload. An "\n" after the "0000" > would break the protocol as the server would read that "\n" in a > context where it is expecting another pkt-line length declaration. > "\n" is not a hex digit, so "0000\n" is horribly horribly broken. O.K. It would probably be more clean to explicitly include terminators in the output (like for final response: sending packfile) and put magical 'flush' line in separate row (separate line of example output). BTW. do "0001" - "0003" pkt-lines are reserved, or just invalid? > >>> This is sent back to the client verbatim. The client responds with >>> another request: >>> >>> 0054want 74730d410fcb6603ace96f1dc55ea6196122532d multi_ack side-band-64k ofs-delta >>> 0032want 7d1665144a3a975c05f1f43902ddaf084e784dbe >>> 0032want 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a >>> 0032want 7e47fe2bd8d01d481f44d7af0531bd93d3b21c01 >>> 0032want 74730d410fcb6603ace96f1dc55ea6196122532d >> >> The semantics (meaning) of those 'want' lines is not described here, >> although one can easily guess that those are commits that client does >> not have, and which do want. In the case of "git clone" those are all >> unique sha1 that client got (what happend if server has detached HEAD?) > > IIRC, HEAD isn't fetched if its detached. > > The client pattern matches the advertisements against the fetch > refspec, which is "refs/heads/*:refs/remotes/origin/*" by default. > HEAD doesn't match the LHS, so it doesn't get wanted by the client. Well, unless client requests 'mirror' clone, where from what I understand "refs/*:refs/*" is implied... but that would also not match HEAD. Hmmm... I would think that "git clone --mirror" would also mirror HEAD if it is detached. > >> It is not clear, but one can guess that set of capabilities that client >> sends (without stuffing behind NUL character this time?) is a supported >> by client and wanted subset of server capabilities. > > Yes. Another oddity. Why the heck we didn't also use the NUL hack > here is a good question. Basically, the NUL hack wasn't necessary > in the server at the time that capabilities were added, because the > server was parsing the line with a fixed position parser. It only > looked at the first 45 characters ("want 0x40"). Anything after > that was assumed to be garbage... like that unnecessary LF. And it was necessary when sending server capabilities because that response cannot be parsed using fixed position parser: HEAD can not exists, and refs have arbitrary (well, up to something less than PATH_MAX for sure) length. > >>> 00000009done >> >> First I thought that this is an error... but not, the 'flush' ("0000") >> is not LF terminated. > > Correct. Again, server only cares that its "done" in a packet. > I think "donedammitsendmeapacknow" is also going to make the current > servers spit back a pack. :-) > >>> >>> "0008NAK\n" >> >> What does this server response mean? That served doesn't need more >> info? > > It means the server is answering a prior flush from the client, > and is saying "I still can't serve you, keep tell me more have". Hmmm... the communication between server and client is not entirely clean. Do I understand correctly that this NAK is response to clients flush after all those "want" lines? And that "0009done" from client tells server that it should send everything it has? > >>> "0023\\002Counting objects: 2797, done.\n" >>> "002b\\002Compressing objects: 0% (1/1177) \r" >>> "002c\\002Compressing objects: 1% (12/1177) \r" >>> "002c\\002Compressing objects: 2% (24/1177) \r" >>> "002c\\002Compressing objects: 3% (36/1177) \r" >>> "002c\\002Compressing objects: 4% (48/1177) \r" >>> "002c\\002Compressing objects: 5% (59/1177) \r" >>> "002c\\002Compressing objects: 6% (71/1177) \r" >>> "0053\\002Compressing objects: 7% (83/1177) \rCompressing objects: 8% (95/1177) \r" ... >>> "005b\\002Compressing objects: 100% (1177/1177) \rCompressing objects: 100% (1177/1177), done.\n" >> >> I guess that it is sideband support: after pkt-length there is number >> of stream (multiplexing), where 2 = \002 means stderr. > > Yes. Actually, 2 means "progress messages, most likely suitable > for stderr". 1 means "pack data". 3 means "fatal error message, > and we're dead now". But it is easily extendable, i.e. sideband > 3 would work, although be ignored, isn't it? By the way, how client does know that server started to send final data, i.e. packfile multiplexed / interleaved with progress reports, and should expect rather than output? > >> I wonder why sometimes it is one line per update, and sometimes there >> is more than one update info stuffed in single line. > > Buffering. There are two processes running on the server side, > git-pack-objects is producing these messages on its stderr, > and the pack data on stdout. Both are actually a pipe read by > git-upload-pack in a select loop. If pack-objects can write two > messages into the pipe buffer before upload-pack is woken to read > them out, upload-pack might find two (or more) messages ready to > read without blocking. These get bundled into a single packet, > because, why not, its easier to code it that way. > > Its most common on the end like that, where we dump 100%, and > then immediately add the ", done" and start a new progress meter. > Its less likely in the middle, where we try to space out the progress > updates to around 1 per second, or 1 per percentage unit. Ahhh... now I understand. Thanks. -- Jakub Narebski Poland