From: Clemens Buchacher <drizzd@aon.at>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Erik Faye-Lund <kusmabite@googlemail.com>,
Jay Soffian <jaysoffian@gmail.com>,
Tay Ray Chuan <rctay89@gmail.com>
Subject: Re: [PATCH 2/2] match_refs: search ref list tail internally
Date: Thu, 28 May 2009 11:26:24 +0200 [thread overview]
Message-ID: <20090528092624.GA8787@localhost> (raw)
In-Reply-To: <7vtz35hfk7.fsf@alter.siamese.dyndns.org>
On Thu, May 28, 2009 at 12:06:32AM -0700, Junio C Hamano wrote:
> It so happens that http-push.c never looked at remote_tail to do further
> processing on the list after match_refs() returned, and that is why your
> patch does not break http-push.c.
>
> Any third-party patch to http-push.c
> that relied on the old guarantee will textually merge cleanly but will
> subtly break with this change.
>
> Other parts of this patch removes the local "remote_tail" variables, and
> it is very clear that they do not have this problem; any third-parth patch
> will break if they used remote_tail after match_refs() returned, so this
> change is a safe one for them.
Yes, I tried to get rid of remote_tail entirely, but I could not come up
with a solution immediately. We could insert to the front of the list
instead. I'll try that.
> I wonder what interaction this change will have with the http-push
> clean-up Ray Chuan has been working on...
For me, t5540 currently segfaults on pu. I'm looking into it.
next prev parent reply other threads:[~2009-05-28 9:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 16:10 Segfault in "git remote show <remote-name>" Erik Faye-Lund
2009-05-25 19:01 ` Clemens Buchacher
2009-05-26 14:27 ` Jay Soffian
2009-05-27 20:13 ` [PATCH 1/2] fix segfault showing an empty remote Clemens Buchacher
2009-05-27 20:13 ` [PATCH 2/2] match_refs: search ref list tail internally Clemens Buchacher
2009-05-28 7:06 ` Junio C Hamano
2009-05-28 9:26 ` Clemens Buchacher [this message]
2009-05-31 14:26 ` [PATCH v2] " Clemens Buchacher
2009-05-26 18:54 ` Segfault in "git remote show <remote-name>" Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528092624.GA8787@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=kusmabite@googlemail.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).