From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 0/3] remove static vars from "builtin-rev-list.c"
Date: Tue, 7 Apr 2009 06:50:12 +0200 [thread overview]
Message-ID: <20090407065012.c6528241.chriscool@tuxfamily.org> (raw)
This patch series removes all static variables from
"builtin-rev-list.c" except the usage string.
This cleans up the code and should please Dscho.
It also makes it possible to remove restrictions on using the
"sho_bisect_vars" function.
list-objects: add "void *data" parameter to show functions
rev-list: remove last static vars used in "show_commit"
rev-list: add "int bisect_show_flags" in "struct rev_list_info"
bisect.c | 8 +++-
bisect.h | 18 ++++----
builtin-pack-objects.c | 6 +-
builtin-rev-list.c | 109 ++++++++++++++++++++++++------------------------
list-objects.c | 9 ++--
list-objects.h | 6 +-
upload-pack.c | 6 +-
7 files changed, 84 insertions(+), 78 deletions(-)
PS: Sorry but it looks like the script I used to send this series has some bugs.
First the date in the email are wrong, and then I have to resend this cover letter
because it did not appear on the mailing list.
reply other threads:[~2009-04-07 4:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407065012.c6528241.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).