From: Heiko Voigt <hvoigt@hvoigt.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Junio C Hamano <gitster@pobox.com>,
Heiko Voigt <git-list@hvoigt.net>,
ydirson@altern.org, git@vger.kernel.org, CVSps@dm.cobite.com
Subject: Re: started a cvsps testsuite Was: Re: [PATCH v3 0/2] cvsimport: add test illustrating a bug in cvsps
Date: Mon, 6 Apr 2009 21:01:49 +0200 [thread overview]
Message-ID: <20090406190148.GB466@macbook.lan> (raw)
In-Reply-To: <49C8667B.5050506@alum.mit.edu>
On Tue, Mar 24, 2009 at 05:50:03AM +0100, Michael Haggerty wrote:
> Heiko Voigt wrote:
> > I just started a very simple but hopefully effective testsuite to
> > collect all the issues we found with cvsps. [...]
> >
> > Maybe Michael can add his tests as well. You should just need to
> > construct the expected cvsps output.
>
> Please note that the cvsps output format itself is not rich enough to
> represent all of the information needed, so it is not trivial to
> construct the "expected" output.
But its possible ;) I have extracted some tests from the scripts you
send and pushed them into the repo. The output format definitely needs
extension. I already included that in the expected output. Maybe you
want to have a look. Tell me what you think.
> The following is from an email that I
> sent to the Mercurial mailing list [1]:
>
> > I spent some time looking into cvsps, and I don't think that its
> > output format, let alone the output itself, is suitable for
> > industrial-strength conversion from CVS. For example, as far as I
> > can tell from my brief investigation:
> >
> > * log messages are not unambiguously separable from the metadata
> >
Thats one issue which could be addressed by escaping the sequences which
lead to the ambiguity.
All issues described below could be addressed by the examples I included in
the tests.
> > * it seems to only allow a single tag per changeset
> >
> > * it seems to only apply tags to single changesets, whereas in CVS
> > files can be added to a tag at different times.
> > ...
> >
> > * it seems to completely ignore a branch tag if no commits were
> > ever made on that branch.
> >
> > * it seems to ignore the effect that a second import to a vendor
> > branch has on the main branch.
>
> You might also be interested to know that there has been some work in
> the Mercurial project on a Python-based "cvsps". I believe they use
> their own version for their cvsimport extension. I don't know how
> different their cvsps is from the original.
Thats indeed interesting I have to try it once the testsuite is ready.
Maybe we can then just replace the original.
cheers Heiko
next prev parent reply other threads:[~2009-04-06 19:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 18:49 [PATCH] cvsimport: add test illustrating a bug in cvsps Heiko Voigt
2009-02-23 20:35 ` Heiko Voigt
2009-02-24 5:00 ` Michael Haggerty
2009-03-02 17:59 ` [PATCH v2 0/1] " Heiko Voigt
2009-03-02 17:59 ` [PATCH v2 1/1] " Heiko Voigt
2009-03-09 11:26 ` [CVSPS PATCH] fix: correct rev order in case commiters clocks were not syncronised Heiko Voigt
2009-03-09 15:02 ` Michael Haggerty
2009-03-18 17:33 ` [PATCH v3 0/2] cvsimport: add test illustrating a bug in cvsps Heiko Voigt
2009-03-18 18:22 ` Junio C Hamano
2009-03-19 10:41 ` Michael J Gruber
2009-03-19 11:00 ` Johannes Schindelin
2009-03-19 11:22 ` Michael J Gruber
2009-03-21 5:41 ` Michael Haggerty
2009-03-23 18:11 ` started a cvsps testsuite Was: " Heiko Voigt
2009-03-23 19:06 ` Martin Langhoff
2009-03-24 4:50 ` Michael Haggerty
2009-04-06 19:01 ` Heiko Voigt [this message]
2009-03-23 17:47 ` Heiko Voigt
2009-03-18 17:33 ` [PATCH v3 1/2] " Heiko Voigt
2009-03-18 17:33 ` [PATCH v3 2/2] cvsimport: extend testcase about patchset order to contain branches Heiko Voigt
2009-03-18 17:34 ` [CVSPS PATCH v2] fix: correct rev order in case commiters clocks were not syncronised Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406190148.GB466@macbook.lan \
--to=hvoigt@hvoigt.net \
--cc=CVSps@dm.cobite.com \
--cc=git-list@hvoigt.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).