On Sat, Apr 04, 2009 at 07:56:36PM -0400, Jeff King wrote: > Ah, I see. You are not asking "was PERL_PATH blank" but rather "does > PERL_PATH exist". And I think that is not the right thing for the > Makefile, as it is unlike any other part of the git Makefile, which > generally does what it is told with the minimum of magic. That sort of > magic generally goes into configure.ac. At a glance, PERL_PATH in configure.ac isn't actually used at the moment, the definition in the Makefile overrides it. > So NO_PERL_MAKEMAKER is _already_ exported, and I don't think there is > any reason to export NO_PERL in the environment (see patch 4/4, which > exports it via GIT-BUILD-OPTIONS). Ok, drop the export then, but do keep at least the if(is empty PERL_PATH) then { set NO_PERL }, even if you won't keep the existence check. -- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85