From: Jeff King <peff@peff.net>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Robin H. Johnson" <robbat2@gentoo.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] NO_PERL support
Date: Fri, 3 Apr 2009 14:37:38 -0400 [thread overview]
Message-ID: <20090403183738.GA15926@coredump.intra.peff.net> (raw)
In-Reply-To: <200904031954.57584.j6t@kdbg.org>
On Fri, Apr 03, 2009 at 07:54:57PM +0200, Johannes Sixt wrote:
> If you base the patch on 'master', you can add this line to test-lib.sh
>
> test -z "$NO_PERL" && test_set_prereq PERL
Thanks, I'm working up a patch using this now.
> [But actually, if I read you patch correctly, NO_PERL will be set in
> t/Makefile only if one runs 'make test' from the main directory. You should
> invent some method to detect missing perl (or that NO_PERL was set) if 'make'
> is run directly from t/.]
Yes, it should go into GIT-BUILD-OPTIONS which gets sourced by
test-lib.sh (and then it not only works with "make test" from "t/", but
also with "sh t????-whatever.sh".
-Peff
next prev parent reply other threads:[~2009-04-03 18:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 7:03 [PATCH] NO_PERL support Robin H. Johnson
2009-04-03 13:20 ` Jeff King
2009-04-03 14:51 ` Johannes Schindelin
2009-04-03 14:53 ` Jeff King
2009-04-03 15:02 ` Johannes Schindelin
2009-04-03 15:11 ` Miklos Vajna
2009-04-03 15:16 ` Jeff King
2009-04-03 17:54 ` Johannes Sixt
2009-04-03 18:37 ` Jeff King [this message]
2009-04-03 15:46 ` Jeff King
2009-04-03 15:59 ` Robin H. Johnson
2009-04-03 16:18 ` Jeff King
2009-04-03 16:25 ` Junio C Hamano
2009-04-03 17:15 ` Jeff King
2009-04-03 20:20 ` Junio C Hamano
2009-04-03 20:56 ` Jeff King
2009-04-03 19:27 ` [PATCH 0/4] " Jeff King
2009-04-03 19:28 ` [PATCH 1/4] commit: abort commit if interactive add failed Jeff King
2009-04-03 19:31 ` [PATCH 2/4] tests: remove exit after test_done call Jeff King
2009-04-03 19:32 ` [PATCH 3/4] Makefile: allow building without perl Jeff King
2009-04-04 22:47 ` Robin H. Johnson
2009-04-04 23:39 ` Jeff King
2009-04-04 23:51 ` Robin H. Johnson
2009-04-04 23:56 ` Jeff King
2009-04-05 0:06 ` Robin H. Johnson
2009-04-07 7:27 ` Jeff King
2009-04-03 19:33 ` [PATCH 4/4] tests: skip perl tests if NO_PERL is defined Jeff King
2009-04-04 23:30 ` Robin H. Johnson
2009-04-04 23:42 ` Jeff King
2009-04-07 7:31 ` [PATCH 0/4] NO_PERL support Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403183738.GA15926@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).