From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sitaram Chamarty <sitaramc@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] give exclude mechanism a debug option
Date: Sun, 8 Feb 2009 03:59:33 -0500 [thread overview]
Message-ID: <20090208085933.GB4392@coredump.intra.peff.net> (raw)
In-Reply-To: <7viqnludiv.fsf@gitster.siamese.dyndns.org>
On Sat, Feb 07, 2009 at 01:45:44PM -0800, Junio C Hamano wrote:
> > Because I would expect "git check-ignore foo/bar | grep ^foo/bar:" to
> > tell me if and how foo/bar is being excluded. But I have to instead
> > check for ^foo and ^foo/bar.
>
> Sorry, I do not understand why you need the downstream pipe that filters
> using grep to begin with.
Sorry, I should have been more clear. The grep was meant to simulate
what my eyes and brain are doing. That is, if I ask "what are patterns
affecting foo/bar?", I expect to see "foo/bar" in the output.
For asking about one path, it may not be that big a deal to see that the
output matches to the input. But if I feed a hundred paths to
check-ignore, I expect to be able to scan the output for the input I put
in.
> Shouldn't "git check-ignore dir/path" talk about the exclude entries that
> caused dir/path to be excluded and no other patterns? And if the reason
Yes, I would think so. Which maybe means using the current "exclude"
code is not appropriate. Because it is really about traversing the
directory structure, excluding as we go. I don't know that you can
directly ask it about a particular path.
-Peff
next prev parent reply other threads:[~2009-02-08 9:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 9:38 How to find out which gitignore blocks my git-add Gonzo
2009-02-06 19:33 ` Jeff King
2009-02-07 1:33 ` Sitaram Chamarty
2009-02-07 6:42 ` Jeff King
2009-02-07 6:44 ` [PATCH 1/2] refactor exclude handling Jeff King
2009-02-07 6:44 ` [PATCH 2/2] give exclude mechanism a debug option Jeff King
2009-02-07 7:38 ` Junio C Hamano
2009-02-07 7:42 ` Junio C Hamano
2009-02-07 11:46 ` Jeff King
2009-02-07 11:44 ` Jeff King
2009-02-07 21:45 ` Junio C Hamano
2009-02-08 8:59 ` Jeff King [this message]
2009-02-08 9:50 ` Junio C Hamano
2009-02-08 9:52 ` Jeff King
2009-02-07 12:44 ` How to find out which gitignore blocks my git-add Sitaram Chamarty
2009-02-07 13:31 ` Jeff King
2009-02-06 22:00 ` Bisani, Alok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090208085933.GB4392@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).