From: Eric Wong <normalperson@yhbt.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] 'git svn info' fixes
Date: Mon, 1 Sep 2008 15:58:31 -0700 [thread overview]
Message-ID: <20080901225831.GA26913@untitled> (raw)
In-Reply-To: <200809011146.44909.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> wrote:
> Eric Wong wrote:
> > Yes. Please maintain compatibility with svn 1.5. The current version
> > of git-svn should strive to maintain compatibility with the current
> > version of svn whenever possible.
>
> Ok, that certainly clarifies the goal.
>
> > > Unfortunately this does raise the question whether the URL-encoding
> > > issue treated in the other series is in fact a similar incompatibility
> > > between 1.4 and 1.5, not a (minor but long-standing) bug in git-svn.
> >
> > It should match svn 1.5 for "git svn info".
> [...]
> > svn log -v `git svn info --url`
> > [should] just work.
> >
> > I seem to recall the rules being slightly different for http(s):// and
> > (file://|svn://) URLs with the command-line client; but my memory may
> > just be fuzzy...
>
> I've finally found a system with SVN 1.4 that I have access to, and
> ran a few tests. I don't have svn:// servers with weird directory
> names at hand, but I could verify that even SVN 1.4 quotes output and
> requires the input to be properly quoted:
>
> $ svn info
> Path: .
> URL: file:///home/thomas/test%20directory%3F
> Repository Root: file:///home/thomas/test%20directory%3F
> [...]
>
> $ svn info file:///home/thomas/test%20directory%3F
> Path: test directory?
> URL: file:///home/thomas/test%20directory%3F
> Repository Root: file:///home/thomas/test%20directory%3F
> [...]
>
> $ svn info file:///home/thomas/'test directory?'
> svn: URL 'file:///home/thomas/test directory?' is not properly URI-encoded
>
> Variations with https:// and SVN 1.5 give the same results. So unless
> I'm missing something, the two patch series are needed to get the
> correct output.
Thank you very much for the fixes an analysis. This series acked and
pushed out to git://git.bogomips.org/git-svn.git
--
Eric Wong
prev parent reply other threads:[~2008-09-01 22:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 19:32 [PATCH 0/6] 'git svn info' fixes Thomas Rast
2008-08-26 19:32 ` [PATCH 1/6] git svn info: tests: let 'init' test run with SVN 1.5 Thomas Rast
2008-08-26 19:32 ` [PATCH 2/6] git svn info: tests: do not use set -e Thomas Rast
2008-08-26 19:32 ` [PATCH 3/6] git svn info: tests: use test_cmp instead of git-diff Thomas Rast
2008-08-26 19:32 ` [PATCH 4/6] git svn info: tests: fix ptouch argument order in setup Thomas Rast
2008-08-26 19:32 ` [PATCH 5/6] git svn info: make info relative to the current directory Thomas Rast
2008-08-26 19:32 ` [PATCH 6/6] git svn info: always quote URLs in 'info' output Thomas Rast
2008-08-27 9:43 ` Eric Wong
2008-08-27 9:53 ` [PATCH 0/6] 'git svn info' fixes Eric Wong
2008-08-28 8:30 ` Thomas Rast
2008-08-29 8:16 ` Eric Wong
2008-08-29 13:42 ` [PATCH 0/2] *** SUBJECT HERE *** Thomas Rast
2008-08-29 13:42 ` [PATCH 1/2] git-svn: match SVN 1.5 behaviour of info' on unknown item Thomas Rast
2008-08-29 13:42 ` [PATCH 2/2] git-svn: fix 'info' tests for unknown items Thomas Rast
2008-08-30 1:03 ` [PATCH 0/2] 'git svn info' fixes Eric Wong
2008-09-01 9:46 ` Thomas Rast
2008-09-01 22:58 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901225831.GA26913@untitled \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).