From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: git-* in test scripts Date: Thu, 28 Aug 2008 20:10:29 -0400 Message-ID: <20080829001029.GB30453@coredump.intra.peff.net> References: <20080828195211.GA3545@mithlond.arda.local> <4B9831F7-3CB8-49CB-A1DB-111481A271FE@cs.indiana.edu> <20080828212346.GA27867@coredump.intra.peff.net> <1C144B19-DA21-4CB4-B872-C1F154B031CF@cs.indiana.edu> <20080828215907.GE27867@coredump.intra.peff.net> <3DE083DB-ADFF-45E7-B3EB-A76985941271@cs.indiana.edu> <20080828230401.GC29609@coredump.intra.peff.net> <7vmyiwd8ot.fsf@gitster.siamese.dyndns.org> <20080828234151.GG29609@coredump.intra.peff.net> <7v7ia0d6u9.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Aug 29 02:11:39 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYraR-0005am-Ds for gcvg-git-2@gmane.org; Fri, 29 Aug 2008 02:11:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754214AbYH2AKb (ORCPT ); Thu, 28 Aug 2008 20:10:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753418AbYH2AKb (ORCPT ); Thu, 28 Aug 2008 20:10:31 -0400 Received: from peff.net ([208.65.91.99]:3386 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbYH2AKb (ORCPT ); Thu, 28 Aug 2008 20:10:31 -0400 Received: (qmail 9871 invoked by uid 111); 29 Aug 2008 00:10:30 -0000 Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.32) with SMTP; Thu, 28 Aug 2008 20:10:30 -0400 Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Thu, 28 Aug 2008 20:10:29 -0400 Content-Disposition: inline In-Reply-To: <7v7ia0d6u9.fsf@gitster.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Aug 28, 2008 at 05:04:46PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Thu, Aug 28, 2008 at 04:24:50PM -0700, Junio C Hamano wrote: > > > >> Test scripts are executed in a special environment whose GIT_EXEC_PATH > >> points at the top of the build tree, where all git-foo lives. > > > > I am not sure how GIT_EXEC_PATH is relevant. We put the git top-level > > directory in the PATH, which is why "git-foo" works at all in the test > > scripts. But the install by default does _not_ put those commands in > > the PATH. So the test scripts serve as a poor example of how to use > > git. The commands contained within them would not run in an ordinary git > > installation. > > Well, I was merely replying to your message. If you admit that tests are > special and a poor example, why did you bring it up? ;-) I don't quite follow you. I think that the tests are actively being used by people to see how they should invoke git, but they are very bad for that, because they are still using the dashed form. So either the people should stop doing that, or the tests should stop using the dashed form. I think the latter is much easier for us to control. I sent a patch for this probably a year ago, but nobody seemed interested. I'm sure it is hopelessly out of date at this point (it was not as easy as a mechanical change because there are other things that look like git-*, like filename arguments to commands). -Peff