From: "Shawn O. Pearce" <spearce@spearce.org>
To: SZEDER GGGbor <szeder@ira.uka.de>
Cc: Lee Marlow <lee.marlow@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] bash: remove redundant check for 'git stash apply' options
Date: Wed, 6 Aug 2008 08:47:10 -0700 [thread overview]
Message-ID: <20080806154710.GB28749@spearce.org> (raw)
In-Reply-To: <1218037523-32266-1-git-send-email-szeder@ira.uka.de>
SZEDER GGGbor <szeder@ira.uka.de> wrote:
> It will never trigger anyway because of the first check, and even if it
> would, it would not offer the command line option.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Oops. I should have caught that. ACK.
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 447cb06..5d60f82 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1427,7 +1427,7 @@ _git_stash ()
> apply,--*)
> __gitcomp "--index"
> ;;
> - show,--*|apply,--*|drop,--*|pop,--*|branch,--*)
> + show,--*|drop,--*|pop,--*|branch,--*)
> COMPREPLY=()
> ;;
> show,*|apply,*|drop,*|pop,*|branch,*)
--
Shawn.
next prev parent reply other threads:[~2008-08-06 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 5:50 [PATCH 0/8] bash completion: more porcelain completions Lee Marlow
2008-08-05 5:50 ` [PATCH 1/8] bash completion: Add completion for 'git clone' Lee Marlow
2008-08-05 5:50 ` [PATCH 2/8] bash completion: Add completion for 'git clean' Lee Marlow
2008-08-05 5:50 ` [PATCH 3/8] bash completion: Add completion for 'git init' Lee Marlow
2008-08-05 5:50 ` [PATCH 4/8] bash completion: Add completion for 'git revert' Lee Marlow
2008-08-05 5:50 ` [PATCH 5/8] bash completion: More completions for 'git stash' Lee Marlow
2008-08-05 5:50 ` [PATCH 6/8] bash completion: Add completion for 'git archive' Lee Marlow
2008-08-05 5:50 ` [PATCH 7/8] bash completion: Add completion for 'git ls-files' Lee Marlow
2008-08-06 15:45 ` [PATCH] bash: remove redundant check for 'git stash apply' options SZEDER Gábor
2008-08-06 15:47 ` Shawn O. Pearce [this message]
2008-08-05 14:29 ` [PATCH 0/8] bash completion: more porcelain completions Shawn O. Pearce
2008-08-05 18:58 ` Junio C Hamano
2008-08-05 19:09 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806154710.GB28749@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lee.marlow@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).