git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: q: git-fetch a tad slow?
Date: Thu, 31 Jul 2008 23:11:41 +0200	[thread overview]
Message-ID: <20080731211141.GA1159@elte.hu> (raw)
In-Reply-To: <20080731210307.GF25138@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> > for strictly local fetch.  If your SSH overhead is ~300 ms this is 
> > only a ~700 ms real time for `git fetch origin`, not 5100 ms.
> > 
> > Is your git-fetch a shell script?  Or a compiled binary?  The port 
> > into C made it go _much_ faster, even though it is still a naive 
> > O(N^2) matching algorithm.  Yea, we still should fix that, but I 
> > think an upgrade to 1.5.4 or later would make the client side 
> > improve consideribly.
> 
> ah, it is a shell script indeed! I'll upgrade to latest.

on another box, with 1.5.4, i have:

 dione:~/tip> time git fetch origin

 real    0m0.481s
 user    0m0.136s
 sys     0m0.060s

 dione:~/tip> time ./tip-fetch
 b714d1a257cca93ba6422ca3276ac80a2cde2b59
 b714d1a257cca93ba6422ca3276ac80a2cde2b59

 real    0m0.273s
 user    0m0.012s
 sys     0m0.020s

that's a 2.66 GHz core2 quad, i.e. a pretty fast box too. As you can see 
most time spent in the tip-fetch case was waiting for the network. So 
there's about 200 msecs of extra CPU cost on the local side. On a CPU 
1-2 generations older that could be up to 1000 msecs or more.

In any case, performance has improved significantly with the C version! 
(I'll still use tip-fetch to squeeze out the last bit of performance, 
but it's quite comparable now.)

Sorry that i didnt notice that titan had 1.5.2 - i almost never notice 
it when i switch between stable git versions. (you guys are doing a 
really good job on compatibility)

	Ingo

  reply	other threads:[~2008-07-31 21:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 16:01 q: git-fetch a tad slow? Ingo Molnar
2008-07-29  5:50 ` Shawn O. Pearce
2008-07-29  9:08   ` Ingo Molnar
2008-07-30  4:48     ` Shawn O. Pearce
2008-07-30 19:06       ` Ingo Molnar
2008-07-30 22:38         ` Shawn O. Pearce
2008-07-31  4:45         ` Shawn O. Pearce
2008-07-31 21:03           ` Ingo Molnar
2008-07-31 21:11             ` Ingo Molnar [this message]
2008-07-31 21:19               ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731211141.GA1159@elte.hu \
    --to=mingo@elte.hu \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).