From: Alex Riesen <raa.lkml@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: GIT 1.6.0-rc1
Date: Wed, 30 Jul 2008 08:10:12 +0200 [thread overview]
Message-ID: <20080730061012.GA4437@blimp.local> (raw)
In-Reply-To: <7vmyk0bb5r.fsf@gitster.siamese.dyndns.org>
Junio C Hamano, Wed, Jul 30, 2008 00:03:44 +0200:
> Alex Riesen <raa.lkml@gmail.com> writes:
> >> Alex, I ran the full test with this, but only on Linux boxes; obviously
> >> not on any flavor of Windows. I think it is correct, and the "first line
> >> of defence" fix is the same as your patch, so I'd assume it would work for
> >> you as well. But extra eyeballs are always appreciated.
> >
> > Well, it works on Cygwin too. And I had my eyeballs on the code
> > (wondered first if it will cause more fs accesses than before: it
> > will, in the racy check. Which is correct, AFAICT)
>
> I thought racy check won't even trigger for gitlinks, no?
>
I didn't know. But now, come to think of it, there wouldn't be much
point - the gitlinks are always compared by content, aren't they?
> ce_modified_check_fs() has 3 call sites:
>
> - the call site in ie_match_stat() is protected with is_racy_timestamp()
> that is always false for gitlinks;
>
> - the call site in ie_modified() we just took care of in the current
> thread;
>
> - the other call site is in ce_smudge_racily_clean_entry(), which is
> called from write_index() but it also is protected with
> is_racy_timestamp() that is always false for gitlinks.
So, the change in ce_modified_check_fs is not really needed, because
the gitlink case is never executed?
next prev parent reply other threads:[~2008-07-30 6:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 0:09 GIT 1.6.0-rc1 Junio C Hamano
2008-07-28 0:44 ` Petr Baudis
2008-07-28 6:38 ` Alex Riesen
2008-07-28 6:44 ` Junio C Hamano
2008-07-28 21:37 ` Alex Riesen
2008-07-29 6:20 ` Junio C Hamano
2008-07-29 8:13 ` Junio C Hamano
2008-07-29 8:36 ` Junio C Hamano
2008-07-29 21:17 ` Alex Riesen
2008-07-29 22:03 ` Junio C Hamano
2008-07-30 6:10 ` Alex Riesen [this message]
2008-07-30 6:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730061012.GA4437@blimp.local \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).