git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: しらいしななこ <nanako3@bluebottle.com>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] git add: add long equivalents of '-u' and '-f' options
Date: Sun, 15 Jun 2008 23:23:29 +0200	[thread overview]
Message-ID: <20080615212329.GB7003@neumann> (raw)
In-Reply-To: <7vlk16cuu2.fsf@gitster.siamese.dyndns.org>

On Sun, Jun 15, 2008 at 01:21:57PM -0700, Junio C Hamano wrote:
> SZEDER Gábor <szeder@ira.uka.de> writes:
> > I think this patch is rather a bugfix in the user interface than a new
> > feature.
> 
> Strictly speaking, this is a new feature but I think the documentation
> value to clarify -u stands for "update" is great enough to make it an
> exception.
Well, my reasoning was that every short option must have a long
equivalent, therefore the lack of long options is a bug (even if this
does not lead to e.g. a runtime error).

> I've rewritten (from empty!  Szeder, next time please write
> sensible commit log message to defend your changes, instead of having _me_
> to defend your changes to others here, like this) the commit log message
> to clarify this point.
Sorry, I though the rationale behind the changes (i.e. "why?") is
trivial even from that one-liner:  add long options, because, well,
they do not exist.
In fact, I considered to write something like "these long options are
'--update' and '--force'" in the commit message.  But I dropped it,
because that explained _what_ the patch does, and I understood that
that should not go into the commit message.

Anyway, I will take care next time.

Regards,
Gábor

      reply	other threads:[~2008-06-15 21:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-14  9:48 [PATCH 1/2] git add: add long equivalents of '-u' and '-f' options SZEDER Gábor
2008-06-14  9:48 ` [PATCH 2/2] bash: add more 'git add' options SZEDER Gábor
     [not found] ` <200806142344.m5ENiLqk020529@mi0.bluebottle.com>
2008-06-15  8:53   ` [PATCH 1/2] git add: add long equivalents of '-u' and '-f' options SZEDER Gábor
2008-06-15 20:21     ` Junio C Hamano
2008-06-15 21:23       ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080615212329.GB7003@neumann \
    --to=szeder@ira.uka.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nanako3@bluebottle.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).