On Fri, Jun 06, 2008 at 05:14:35PM -0700, Junio C Hamano wrote: > If that is the case, you might want to check how parse_commit_buffer() in > commit.c builds "parents" list. It is a standard pattern to append to the > list using commit_list_insert() and that is the reason why it returns a > pointer. Ah, great, then this patch is not necessary. I removed it from my working branch. Thanks.