From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Florian Koeberle <florianskarten@web.de>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH v3 19/23] Added WorkTree class which can be constructed over Repository.
Date: Fri, 6 Jun 2008 02:23:07 +0200 [thread overview]
Message-ID: <200806060223.07384.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1211574872-23676-20-git-send-email-florianskarten@web.de>
fredagen den 23 maj 2008 22.34.28 skrev Florian Koeberle:
> ---
> .../src/org/spearce/jgit/lib/Repository.java | 57 +++++++++++++++++
> .../src/org/spearce/jgit/lib/WorkTree.java | 67 ++++++++++++++++++++
> 2 files changed, 124 insertions(+), 0 deletions(-)
> create mode 100644 org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java
>
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
> + public Commit setupHEADRef(final String remoteBranch, final String branch)
> + throws IOException {
> + Commit mapCommit = mapCommit(remoteBranch);
> + String refName = Constants.HEADS_PREFIX + "/" + branch;
> + LockFile masterRef = lockRef(refName);
> + try {
> + masterRef.write(mapCommit.getCommitId());
> + masterRef.commit();
> + } finally {
> + masterRef.unlock();
> + }
> + writeSymref(Constants.HEAD, refName);
> + return mapCommit;
> + }
Shouldn't someone be calling this?
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WorkTree.java
> + /**
> + * Closes the git repository of this project.
> + */
> + public void closeRepository() {
> + repository.close();
> + }
This is redundant. Very few callers need it and those can just as well
call getRepsitory().close() anyway.
next prev parent reply other threads:[~2008-06-06 0:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 20:34 [JGIT PATCH v3 0/23] Implementation of a file tree iteration using ignore rules Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 01/23] Added the class InvalidPatternException Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 02/23] Added the class FileNameMatcher and a test class for it Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 03/23] Added the interface FilePattern Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 04/23] Added the class Rule Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 05/23] Added the iterface Rules Florian Koeberle
2008-06-06 0:22 ` Robin Rosenberg
2008-05-23 20:34 ` [JGIT PATCH v3 06/23] Added the class FileNamePattern Florian Koeberle
2008-06-06 0:22 ` Robin Rosenberg
2008-05-23 20:34 ` [JGIT PATCH v3 07/23] Added the class FilePathPattern Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 08/23] Added the class IgnoreRuleListFactory Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 09/23] Added a Rules interface implementation and a factory for it Florian Koeberle
2008-06-06 0:23 ` Robin Rosenberg
2008-05-23 20:34 ` [JGIT PATCH v3 10/23] Added test class OverallIgnoreRulestest Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 11/23] Added the class PathNotInProjectDirectoryException Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 12/23] Added the class AddRuleListFactory Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 13/23] Formatted Constants class Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 14/23] Added constant REPOSITORY_DIRECTORY_NAME to " Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 15/23] Added class AddRulesFactory Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 16/23] Added the class LightFileTreeIterator and a test for it Florian Koeberle
2008-05-31 10:03 ` [JGIT PATCH v3.1 " Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 17/23] Added class LightFileTreeIterable Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 18/23] Added path related constants to the Constants class Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 19/23] Added WorkTree class which can be constructed over Repository Florian Koeberle
2008-06-06 0:23 ` Robin Rosenberg [this message]
2008-05-23 20:34 ` [JGIT PATCH v3 20/23] Added the class NoGitRepositoryFoundException Florian Koeberle
2008-06-06 0:23 ` Robin Rosenberg
2008-06-08 16:14 ` Florian Köberle
2008-06-08 21:05 ` Robin Rosenberg
2008-05-23 20:34 ` [JGIT PATCH v3 21/23] Formatted Repository class Florian Koeberle
2008-06-06 0:23 ` Robin Rosenberg
2008-05-23 20:34 ` [JGIT PATCH v3 22/23] Added findWorkTree method to " Florian Koeberle
2008-05-23 20:34 ` [JGIT PATCH v3 23/23] Added the test class AddCommandIterationTest Florian Koeberle
2008-05-31 10:09 ` [JGIT PATCH v3.1 " Florian Koeberle
2008-06-06 0:23 ` [JGIT PATCH v3 " Robin Rosenberg
2008-05-31 10:17 ` [JGIT PATCH v3 0/23] Implementation of a file tree iteration using ignore rules Florian Köberle
2008-06-06 0:22 ` Robin Rosenberg
2008-06-08 16:37 ` Florian Köberle
2008-06-08 21:28 ` Robin Rosenberg
2008-06-09 17:11 ` Florian Köberle
2008-06-07 8:43 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806060223.07384.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=florianskarten@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).