From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Rast Subject: Re: [PATCH] git-add--interactive: manual hunk editing mode Date: Thu, 5 Jun 2008 11:02:05 +0200 Message-ID: <200806051102.16965.trast@student.ethz.ch> References: <200805232221.45406.trast@student.ethz.ch> <200805291737.53291.trast@student.ethz.ch> <20080529185808.GA2140@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2381561.GNdaNpyrUt"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org To: Jeff King X-From: git-owner@vger.kernel.org Thu Jun 05 11:02:52 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1K4BMp-0007or-J0 for gcvg-git-2@gmane.org; Thu, 05 Jun 2008 11:02:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbYFEJBt (ORCPT ); Thu, 5 Jun 2008 05:01:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751721AbYFEJBt (ORCPT ); Thu, 5 Jun 2008 05:01:49 -0400 Received: from xsmtp0.ethz.ch ([82.130.70.14]:9628 "EHLO XSMTP0.ethz.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbYFEJBs (ORCPT ); Thu, 5 Jun 2008 05:01:48 -0400 Received: from xfe1.d.ethz.ch ([82.130.124.41]) by XSMTP0.ethz.ch with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Jun 2008 11:01:46 +0200 Received: from vpn-global-dhcp3-023.ethz.ch ([129.132.210.23]) by xfe1.d.ethz.ch over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Jun 2008 11:01:46 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) In-Reply-To: <20080529185808.GA2140@sigill.intra.peff.net> X-OriginalArrivalTime: 05 Jun 2008 09:01:46.0519 (UTC) FILETIME=[C84CEA70:01C8C6EA] Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --nextPart2381561.GNdaNpyrUt Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline You wrote: > On Thu, Jun 05, 2008 at 09:53:54AM +0200, Thomas Rast wrote: >=20 > > On the other hand it would be just as powerful. Manually splitting a > > hunk is, in the general case, only possible in "my" scheme. However, > > to make any difference, you later have to answer 'n' to some of the > > sub-hunks. So in "your" scheme, you could just have deleted the lines > > in question. >=20 > Sorry, I've gotten lost in which is mine and which is yours. Yours is > the original patch or this patch? Mine is the proposal that spawned this > patch, or my comments on this patch? I should have provided a definition, sorry. By "your" scheme, I meant the one where one is restricted to deleting existing lines, and thus deletes '-' lines to disable them; by "my" scheme, where one is free to edit and changes '-' lines to context to disable them. At least it's my current understanding that, under the above definition, "your" scheme is what you actually proposed in http://www.spinics.net/lists/git/msg67478.html [why doesn't Google find gmane?] but I misunderstood and implemented "my" scheme. [Let's just forget about the original patch at the top of the thread; in retrospect, it _is_ clunky, and the UI didn't get any replies in favour.] =2D Thomas =2D-=20 Thomas Rast trast@student.ethz.ch --nextPart2381561.GNdaNpyrUt Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBIR6uYqUud07tmzP0RAo1MAKCJQp4QQc3Bk4m0mR1wysXD9pZkoACeLmI2 u2JvqDQKiiEzieCoCM27k/o= =2XqW -----END PGP SIGNATURE----- --nextPart2381561.GNdaNpyrUt--