From: Gerrit Pape <pape@smarden.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Kai Blin <kai.blin@gmail.com>
Subject: Re: [PATCH] gitweb: Fix "next" link on bottom of page
Date: Mon, 2 Jun 2008 17:02:19 +0000 [thread overview]
Message-ID: <20080602170219.8487.qmail@86b125e51c7491.315fe32.mid.smarden.org> (raw)
In-Reply-To: <20080602095348.16843.24351.stgit@localhost.localdomain>
On Mon, Jun 02, 2008 at 11:54:41AM +0200, Jakub Narebski wrote:
> This bug was caused by the fact that git_header_html() modified
> parameters in $cgi->param(...) when generating search form, and
> href(-replay, ...) uses paramemeters values from $cgi, not saved in
> variables (although it could).
>
> This fixes mentioned bug, not only in the case of 'log' view, but in
> all cases (although it is possible that this bug doesn't occur for
> other pages).
> gitweb/gitweb.perl | 13 +++++--------
> 1 files changed, 5 insertions(+), 8 deletions(-)
Hi, this fixes the bottom 'next' link in the log view for me, so
Tested-by: Gerrit Pape <pape@smarden.org>
Thanks, Gerrit.
prev parent reply other threads:[~2008-06-02 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 18:10 [PATCH] gitweb: fix "next" link on bottom of commit log page Gerrit Pape
2008-05-30 8:12 ` Jakub Narebski
2008-06-02 8:52 ` Jakub Narebski
2008-06-02 9:54 ` [PATCH] gitweb: Fix "next" link on bottom of page Jakub Narebski
2008-06-02 17:02 ` Gerrit Pape [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602170219.8487.qmail@86b125e51c7491.315fe32.mid.smarden.org \
--to=pape@smarden.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=kai.blin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).