git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Rob Shearman <robertshearman@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.
Date: Mon, 2 Jun 2008 00:04:10 +0200	[thread overview]
Message-ID: <20080601220410.GD29404@genesis.frugalware.org> (raw)
In-Reply-To: <1096648c0806010828yf4f07ebt3f758f41cab5cdfd@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:
> +	setup_git_directory_gently( NULL );
>  	git_config(git_imap_config, NULL);

I know this is just about cosmetics, but the style of the rest of the
code would suggest using

        setup_git_directory_gently(NULL);

not 

        setup_git_directory_gently( NULL );

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-06-01 22:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-01 15:28 [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree Rob Shearman
2008-06-01 22:04 ` Miklos Vajna [this message]
2008-06-02  8:18   ` Rob Shearman
2008-06-02 13:21     ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080601220410.GD29404@genesis.frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=git@vger.kernel.org \
    --cc=robertshearman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).