From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] Make "git-remote rm" delete refs acccording to fetch specs
Date: Sun, 1 Jun 2008 00:40:47 -0400 [thread overview]
Message-ID: <20080601044047.GF12896@spearce.org> (raw)
In-Reply-To: <20080601042804.GA32293@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> To avoid deleting refs used by another remote we only clear refs
> that are unique to this remote. This prevents `git prune rm alt`
> from removing the refs used by say origin if alt was just using a
> different URL for the same repository.
Hmm. You probably should squash this test case into that patch.
--8<--
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index 0d7ed1f..96e461b 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -182,6 +182,18 @@ test_expect_success 'add alt && prune' '
git rev-parse --verify refs/remotes/origin/side2)
'
+test_expect_success 'rm alt' '
+ (cd alttst &&
+ git remote rm alt &&
+ tokens_match z z$(git config remote.alt.url) &&
+ tokens_match z z$(git config remote.alt.fetch) &&
+ git rev-parse --verify refs/remotes/origin/side2 &&
+ git remote rm origin &&
+ tokens_match z z$(git config remote.alt.url) &&
+ tokens_match z z$(git config remote.alt.fetch) &&
+ ! git rev-parse --verify refs/remotes/origin/side2)
+'
+
cat > one/expect << EOF
apis/master
apis/side
--
Shawn.
next prev parent reply other threads:[~2008-06-01 4:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 3:59 [PATCH 3/3] Make "git-remote rm" delete refs acccording to fetch specs Shawn O. Pearce
2008-06-01 4:28 ` [PATCH 3/3 v2] " Shawn O. Pearce
2008-06-01 4:40 ` Shawn O. Pearce [this message]
2008-06-01 5:29 ` Junio C Hamano
2008-06-01 6:30 ` Shawn O. Pearce
2008-06-01 8:28 ` Junio C Hamano
2008-06-02 17:10 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080601044047.GF12896@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).