git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Kevin Green <Kevin.T.Green@morganstanley.com>
To: Simon Hausmann <simon@lst.de>, git@vger.kernel.org
Subject: Re: [PATCH] git-p4: Work around race between p4_edit and p4_change
Date: Fri, 11 Apr 2008 12:27:59 -0400	[thread overview]
Message-ID: <20080411162759.GO22542@morganstanley.com> (raw)
In-Reply-To: <20080403195135.GI22542@morganstanley.com>

On 04/03/08 15:51:35, Kevin Green wrote:
> On 04/03/08 14:45:38, Kevin Green wrote:
> > On 04/03/08 14:32:32, Simon Hausmann wrote:
> > > 
> > > Last but not least we could of course also generate the entire Files: section 
> > > ourselves, using 'p4 change -o' just to get the rest of the template right.
> > > 
> > > I almost prefer the last approach, since we know the base depot path and the 
> > > relative paths of all edited/added files.
> > > 
> > > What do you think?
> > > 
> > 
> > Thank you...  That's the right approach.  Stop as soon as we get to the Files:
> > section and then just add in the depot + filepath string for each change...
> > 
> 
> And here's the patch that does what we just described...
> 

Haven't heard comment back on this patch.  Am wondering if it will be applied
to git, or if I need to start thinking about maintaining it myself on my end,
or if it's not appropriate and I should re-submit something else.


Thanks

--Kevin

      reply	other threads:[~2008-04-11 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01 22:28 [PATCH] git-p4: Fix race between p4_edit and p4_change Kevin Green
2008-04-03 18:32 ` Simon Hausmann
2008-04-03 18:45   ` Kevin Green
2008-04-03 19:51     ` [PATCH] git-p4: Work around " Kevin Green
2008-04-11 16:27       ` Kevin Green [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080411162759.GO22542@morganstanley.com \
    --to=kevin.t.green@morganstanley.com \
    --cc=git@vger.kernel.org \
    --cc=simon@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).