From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Teemu Likonen <tlikonen@iki.fi>, git@vger.kernel.org
Subject: Re: BUG: "git add --interactive" does not work with UTF-8 filenames
Date: Wed, 2 Apr 2008 12:17:14 +0100 [thread overview]
Message-ID: <200804021317.16007.jnareb@gmail.com> (raw)
In-Reply-To: <7v63v1ccmb.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > git-config(1):
> >
> > core.quotepath::
> > The commands that output paths (e.g. `ls-files`,
> > `diff`), when not given the `-z` option, will quote
> > "unusual" characters in the pathname by enclosing the
> > pathname in a double-quote pair and with backslashes the
> > same way strings in C source code are quoted. If this
> > variable is set to false, the bytes higher than 0x80 are
> > not quoted but output as verbatim. Note that double
> > quote, backslash and control characters are always
> > quoted without `-z` regardless of the setting of this
> > variable.
> >
> > Since 1.5.2.2 (I think), or at least 1.5.3, so you have new enough
> > version of git (git is now at 1.5.5-rc2).
>
> Yes, but I do not think "add -i" unwraps the path quoting. I think it
> should, but I do not think I bothered to. Because it is trivial to do by
> any aspiring git hacker wannabes, I left it as an exercise to readers when
> I did the "interactive" as a quick-and-dirty hack (aka "demonstration").
By the way, the code to unwrap the path quoting can be found in gitweb
as unescape() subroutine... or git-add--interactive can use '-z' switch.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-04-02 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 19:32 BUG: "git add --interactive" does not work with UTF-8 filenames Teemu Likonen
2008-04-01 20:08 ` Jakub Narebski
2008-04-01 20:29 ` BUG: "git add --interactive" does not work with UTF-8 filenames if core.quotepath=true Teemu Likonen
2008-04-02 0:41 ` BUG: "git add --interactive" does not work with UTF-8 filenames Junio C Hamano
2008-04-02 11:17 ` Jakub Narebski [this message]
2008-04-02 15:50 ` Junio C Hamano
2008-04-02 17:06 ` [PATCH] Describe the bug about handling non-Ascii filenames in 'git add -i' Teemu Likonen
2008-04-02 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804021317.16007.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).