From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, git@vger.kernel.org
Subject: Re: git-log segfault on 00 graft
Date: Wed, 5 Mar 2008 00:06:30 -0500 [thread overview]
Message-ID: <20080305050630.GX8410@spearce.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0803041908210.22527@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Tue, 4 Mar 2008, Jan Engelhardt wrote:
>
> > I was playing a bit with grafts, and actually did this:
> >
> > echo '839affa3313011da783b5b8074a5c9805ee8503a
> > 0000000000000000000000000000000000000000' >.git/info/grafts
> >
> > running `git log --topo-order` causes a segfault. Yes, I probably
> > "should not be doing that", but I think it at least should not
> > segfault.
>
> Well, I agree with the first, but not the latter. grafts are a really
> core and plumbing thing, and if you set it to something nonsensical, I
> think you should expect something like a segmentation fault.
I'm sorry, I don't know where you learned to program Dscho, but
my mentors always taught me that user input should be handled
with care, and SIGSEGV / SIGBUS / SIGILL is not handling with
care!
We tell users to popuate the .git/info/grafts file. By hand.
Its user input. We shouldn't segfault over a malformed entry.
--
Shawn.
next prev parent reply other threads:[~2008-03-05 5:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 18:57 git-log segfault on 00 graft Jan Engelhardt
2008-03-04 19:09 ` Johannes Schindelin
2008-03-05 5:06 ` Shawn O. Pearce [this message]
2008-03-05 12:43 ` Johannes Schindelin
2008-03-05 5:27 ` Björn Steinbrink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305050630.GX8410@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jengelh@computergmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).