From: Christian Couder <chriscool@tuxfamily.org>
To: Xavier Maillard <xma@gnu.org>
Cc: Junio C Hamano <gitster@pobox.com>,
pascal@obry.net, nanako3@bluebottle.com, git@vger.kernel.org
Subject: Re: [PATCH 1/2] help: add "man.viewer" config var to use "woman" or "konqueror"
Date: Mon, 3 Mar 2008 08:20:52 +0100 [thread overview]
Message-ID: <200803030820.52842.chriscool@tuxfamily.org> (raw)
In-Reply-To: <200803010100.m21105LU008843@localhost.localdomain>
Le samedi 1 mars 2008, Xavier Maillard a écrit :
> Looking at this exchange really makes me suspect that these
> things should not be in C. Every time Emacs updates we need
> recompilation? Yuck.
>
> In fact, I am pretty confident that emacsclient has always
> printed its version onto stdout so I do not think we need to
> recompile every week :)
On my Kubuntu Feisty development machine with the stock emacs
21.4a+1-2ubuntu1.1 package I get:
$ emacsclient --version
emacsclient 21.4
$ emacsclient --version 2>/dev/null
$ emacsclient --version 1>/dev/null
emacsclient 21.4
And I don't think it specific to Kubuntu because I remenber getting the same
with emacs21 (before installing emacs22) on another (Debian testing)
machine.
> What was the reason we gave up calling out to a single generic
> scripted wrapper that the users can just munge to suit their
> tastes?
I didn't gave up, I am just waiting for the implementation of a scripted
wrapper in git-mergetool.sh, that is now in 'pu', to mature. Then I will
steal it so we have the same for git help.
> Good question. Though I find chriscool's implementation nicely
> thought.
Thanks.
> With the modifications I made, this works as expected
> with either emacs22 and emacs23 (aka CVS). What's more, how a
> user could have tested if emacsclient was provided in the right
> version using a generic scripted wrapper ?
I agree that it's better to do it for the users.
In fact just after this email, I will send a patch to "run_command.c" named:
"Redirect stderr to a pipe before redirecting stdout to stderr"
that will make my last patches to "help.c" work with both Emacs21 and
Emacs22.
> I guess, chriscool should provide a more consistent emacsclient
> wrapper with support for GNU Emacs version >= 21. This won't be
> an enormous amount of work to do it (I can help him if he wants
> to but I do not want to steal the paternity of his idea).
It would help if you could test with Emacs23 as I didn't installed it.
Thank you for testing my patches.
Christian.
next prev parent reply other threads:[~2008-03-03 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 4:19 [PATCH 1/2] help: add "man.viewer" config var to use "woman" or "konqueror" Christian Couder
2008-02-29 2:00 ` Xavier Maillard
2008-02-29 7:14 ` Christian Couder
2008-02-29 7:46 ` Junio C Hamano
2008-03-01 1:00 ` Xavier Maillard
2008-03-03 7:20 ` Christian Couder [this message]
2008-03-01 1:00 ` [PATCH AMENDED] " Xavier Maillard
2008-03-01 2:14 ` Junio C Hamano
2008-03-03 7:38 ` Christian Couder
2008-03-03 7:42 ` Jakub Narebski
2008-03-03 19:07 ` Christian Couder
2008-02-29 2:00 ` [PATCH 1/2] " Xavier Maillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803030820.52842.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@bluebottle.com \
--cc=pascal@obry.net \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).