git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] mergetool: clarify local/remote terminology
Date: Thu, 28 Feb 2008 03:43:28 -0500	[thread overview]
Message-ID: <20080228084328.GA18350@coredump.intra.peff.net> (raw)
In-Reply-To: <20080225184648.GC15131@sigill.intra.peff.net>

On Mon, Feb 25, 2008 at 01:46:48PM -0500, Jeff King wrote:

> > On Thu, Feb 21, 2008 at 12:12 AM, Jay Soffian <jaysoffian@gmail.com> wrote:
> > > Always calling the thing on the left-side of a merge "local" and on the
> > >  right side "remote" isn't correct. You could be rebasing, in which case
> > >  the left side is the new base/upstream and the right side is the saved
> > >  commits which are being re-applied. So,
> 
> I'll try out your patch and comment next time I use it.

I finally got a chance to use this today (hey, I don't get a lot of
conflicts!).

I like it; I think it made it a lot more obvious which side was which
during the rebase. I checked with cherry-pick, as well; it more or less
makes sense, except that the cherry-picked commit is called "upstream."
Which sort of makes sense, but it would be nice to call it something
more obvious. Unfortunately I'm not sure that there is a good way to
determine we are in a failed cherry-pick (probably a failed 'revert' is
in a similar situation).

So like I said before, I think the eventual "right" thing is to have a
more verbose status file. But in the meantime, I think this patch is
sensible.

-Peff

  parent reply	other threads:[~2008-02-28  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21  5:12 [RFC/PATCH] mergetool: clarify local/remote terminology Jay Soffian
2008-02-25 14:31 ` Jay Soffian
2008-02-25 18:46   ` Jeff King
2008-02-25 19:07     ` Jay Soffian
2008-02-25 19:21       ` Jeff King
2008-02-25 20:09         ` Jay Soffian
2008-02-25 20:11           ` Jeff King
2008-02-28  8:43     ` Jeff King [this message]
2008-02-29  5:47       ` Junio C Hamano
2008-03-01  4:41         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228084328.GA18350@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).