From: Mike Hommey <mh@glandium.org>
To: Ken.Fuchs@bench.com
Cc: git@vger.kernel.org
Subject: Re: FW: git via http protocol _and_ a proxy using NTLM authentication -- git 1.5.4.2 & curl 7.18.0
Date: Wed, 27 Feb 2008 08:29:52 +0100 [thread overview]
Message-ID: <20080227072952.GA27806@glandium.org> (raw)
In-Reply-To: <20080227072012.GA23423@glandium.org>
On Wed, Feb 27, 2008 at 08:20:12AM +0100, Mike Hommey wrote:
> On Tue, Feb 26, 2008 at 05:46:21PM -0600, Ken.Fuchs@bench.com wrote:
> > > Well, the CURLOPT_PROXY is set in transport.c as well which
> > > your patch didn't address.
> >
> > Thanks, I just did a similar patch to transport.c:
> >
> > $ diff -u ../git-1.5.4.2/transport.c.orig \
> > ../git-1.5.4.2/transport.c
> > @@ -456,7 +456,8 @@
> > if (transport->remote->http_proxy)
> > curl_easy_setopt(slot->curl, CURLOPT_PROXY,
> > transport->remote->http_proxy);
> > -
> > + curl_easy_setopt(slot->curl, CURLOPT_PROXYAUTH,
> > (long)CURLAUTH_NTLM);
> > + curl_easy_setopt(slot->curl, CURLOPT_PROXYUSERPWD,
> > "<user-id>:<password>");
> > if (start_active_slot(slot)) {
> > run_active_slot(slot);
> > if (results.curl_result != CURLE_OK) {
> > $
>
> Starting with curl 7.14.1, you're supposed to be able to use the
> http://user:pass@proxy/ syntax, though I'm not sure it deals well with
> NTLM domains. You can probably leave CURLOPT_PROXYUSERPWD out if you
> set your proxy url correctly.
>
> As for CURLOPT_PROXYAUTH, it would be better to set it from another
> config.
Or we should set it to CURLOPT_AUTHANY by default.
Mike
next prev parent reply other threads:[~2008-02-27 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 23:46 FW: git via http protocol _and_ a proxy using NTLM authentication -- git 1.5.4.2 & curl 7.18.0 Ken.Fuchs
2008-02-27 7:20 ` Mike Hommey
2008-02-27 7:29 ` Mike Hommey [this message]
2008-02-27 7:36 ` [PATCH] Set proxy override with http_init() Mike Hommey
2008-02-27 19:18 ` Junio C Hamano
2008-02-27 19:59 ` Daniel Barkalow
2008-02-27 20:05 ` Mike Hommey
2008-02-27 20:35 ` Mike Hommey
2008-02-27 20:39 ` Daniel Barkalow
-- strict thread matches above, loose matches on Subject: below --
2008-02-29 20:06 FW: git via http protocol _and_ a proxy using NTLM authentication -- git 1.5.4.2 & curl 7.18.0 Ken.Fuchs
2008-02-29 20:32 ` Mike Hommey
2008-02-28 22:04 Ken.Fuchs
2008-02-29 0:59 ` Johannes Schindelin
2008-02-27 23:43 Ken.Fuchs
2008-02-28 0:10 ` Johannes Schindelin
2008-02-26 21:43 Ken.Fuchs
2008-02-26 22:01 ` Daniel Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227072952.GA27806@glandium.org \
--to=mh@glandium.org \
--cc=Ken.Fuchs@bench.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).