* [PATCH] git-p4: Fix an obvious typo
@ 2008-02-02 8:11 Tommy Thorn
2008-02-03 18:36 ` Simon Hausmann
0 siblings, 1 reply; 2+ messages in thread
From: Tommy Thorn @ 2008-02-02 8:11 UTC (permalink / raw
To: git
The regexp "$," can't match anything. Clearly not intended.
This was introduced in ce6f33c8 which is quite a while ago.
Signed-off-by: Tommy Thorn <tommy-git@thorn.ws>
---
contrib/fast-import/git-p4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index c80a6da..553e237 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1670,7 +1670,7 @@ class P4Clone(P4Sync):
depotPath = args[0]
depotDir = re.sub("(@[^@]*)$", "", depotPath)
depotDir = re.sub("(#[^#]*)$", "", depotDir)
- depotDir = re.sub(r"\.\.\.$,", "", depotDir)
+ depotDir = re.sub(r"\.\.\.$", "", depotDir)
depotDir = re.sub(r"/$", "", depotDir)
return os.path.split(depotDir)[1]
--
1.5.4.rc5.5.gab98
____________________________________________________________________________________
Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-p4: Fix an obvious typo
2008-02-02 8:11 [PATCH] git-p4: Fix an obvious typo Tommy Thorn
@ 2008-02-03 18:36 ` Simon Hausmann
0 siblings, 0 replies; 2+ messages in thread
From: Simon Hausmann @ 2008-02-03 18:36 UTC (permalink / raw
To: Tommy Thorn; +Cc: git, Junio C Hamano
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
On Saturday 02 February 2008 09:11:44 Tommy Thorn wrote:
> The regexp "$," can't match anything. Clearly not intended.
>
> This was introduced in ce6f33c8 which is quite a while ago.
>
> Signed-off-by: Tommy Thorn <tommy-git@thorn.ws>
Acked-by: Simon Hausmann <simon@lst.de>
Simon
> ---
> contrib/fast-import/git-p4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index c80a6da..553e237 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1670,7 +1670,7 @@ class P4Clone(P4Sync):
> depotPath = args[0]
> depotDir = re.sub("(@[^@]*)$", "", depotPath)
> depotDir = re.sub("(#[^#]*)$", "", depotDir)
> - depotDir = re.sub(r"\.\.\.$,", "", depotDir)
> + depotDir = re.sub(r"\.\.\.$", "", depotDir)
> depotDir = re.sub(r"/$", "", depotDir)
> return os.path.split(depotDir)[1]
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-03 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 8:11 [PATCH] git-p4: Fix an obvious typo Tommy Thorn
2008-02-03 18:36 ` Simon Hausmann
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).