From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
git@vger.kernel.org
Subject: Re: git-browse-help?
Date: Sat, 15 Dec 2007 17:25:18 -0500 [thread overview]
Message-ID: <20071215222518.GL14735@spearce.org> (raw)
In-Reply-To: <20071215111154.GB3447@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
> -- >8 --
> teach bash completion to treat commands with "--" as plumbing
>
> There is a convention that commands containing a double-dash
> are implementation details and not to be used by mortals. We
> should automatically remove them from the completion
> suggestions as plumbing.
>
> Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 58e0e53..2fd32db 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -291,7 +291,7 @@ __git_commands ()
> for i in $(git help -a|egrep '^ ')
> do
> case $i in
> - add--interactive) : plumbing;;
> + *--*) : plumbing pattern;;
> applymbox) : ask gittus;;
> applypatch) : ask gittus;;
> archimport) : import;;
> @@ -308,7 +308,6 @@ __git_commands ()
> diff-tree) : plumbing;;
> fast-import) : import;;
> fsck-objects) : plumbing;;
> - fetch--tool) : plumbing;;
> fetch-pack) : plumbing;;
> fmt-merge-msg) : plumbing;;
> for-each-ref) : plumbing;;
--
Shawn.
next prev parent reply other threads:[~2007-12-15 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 9:28 git-browse-help? Jeff King
2007-12-14 17:38 ` git-browse-help? Junio C Hamano
2007-12-15 10:08 ` git-browse-help? Jeff King
2007-12-15 11:01 ` git-browse-help? Jeff King
2007-12-15 11:11 ` git-browse-help? Jeff King
2007-12-15 19:25 ` git-browse-help? Junio C Hamano
2007-12-15 22:25 ` Shawn O. Pearce [this message]
2007-12-15 19:26 ` git-browse-help? Junio C Hamano
2007-12-16 7:21 ` git-browse-help? Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071215222518.GL14735@spearce.org \
--to=spearce@spearce.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).