From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "H.Merijn Brand" <h.m.brand@xs4all.nl>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Andreas Ericsson <ae@op5.se>,
git@vger.kernel.org, Sam Vilain <sam@vilain.net>
Subject: Re: Building git-1.5.3.7 on HP-UX 11.00
Date: Tue, 11 Dec 2007 03:54:40 -0500 [thread overview]
Message-ID: <20071211085440.GK14735@spearce.org> (raw)
In-Reply-To: <7vfxy9fxh3.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> "H.Merijn Brand" <h.m.brand@xs4all.nl> writes:
>
> > 3 I am willing to believe that HP_UX' vsnprintf () is broken, or
> > at least does not conform to the expectations in the GNU world,
> > but chickening out like the way strbuf_addf () does is maybe a
> > bit too rude, so I forced a minimum of 64bytes available. That
> > fixes a lot!
> >
> > but it still breaks t4013 :(
>
> I think Shawn had something similar for Solaris, and if it is a small
> cost to help portability, it does not feel so bad.
My Solaris change is already in your tree; on Solaris vnsprintf
will return -1 if the input buffer we gave it had a length of 0.
This can happen at odd times, depending on what is already in the
strbuf and how its buffer is. :)
The fix for Solaris turned out to be just make sure there is at
least 1 byte in the buffer before calling vsnprintf().
> > + git-index-pack -o tmp.idx test-2-7f8ead892057e78576c0329a70cc83afb113f117.pack
> > fatal: serious inflate inconsistency
>
> That sounds like a broken zlib X-<.
I think this is actually a broken pread(). Its been reported
multiple times by different people on HP-UX. Compiling with
NO_PREAD=1 resolves the issues for everyone who has tried it.
Jakub asked me for an autoconf test to look for this sort of
breakage in pread(), I have yet to come up with a theory for
what sort of breakage HP-UX is showing us here, let alone write
a test for it.
--
Shawn.
next prev parent reply other threads:[~2007-12-11 8:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 13:09 Building git-1.5.3.7 on HP-UX 11.00 H.Merijn Brand
2007-12-04 13:44 ` Johannes Schindelin
2007-12-04 14:03 ` H.Merijn Brand
2007-12-04 14:40 ` Johannes Schindelin
2007-12-04 15:01 ` H.Merijn Brand
2007-12-04 15:14 ` Andreas Ericsson
2007-12-04 15:22 ` H.Merijn Brand
2007-12-04 15:39 ` Johannes Schindelin
2007-12-04 15:56 ` H.Merijn Brand
2007-12-04 16:28 ` Johannes Schindelin
2007-12-05 10:49 ` H.Merijn Brand
2007-12-04 18:05 ` Junio C Hamano
2007-12-04 22:25 ` H.Merijn Brand
2007-12-04 22:46 ` Johannes Schindelin
2007-12-05 8:08 ` H.Merijn Brand
2007-12-04 22:45 ` [PATCH] Do not rely on the exit status of "unset" for unset variables Johannes Schindelin
2007-12-05 8:01 ` H.Merijn Brand
2007-12-10 14:51 ` Building git-1.5.3.7 on HP-UX 11.00 H.Merijn Brand
2007-12-11 8:26 ` Junio C Hamano
2007-12-11 8:54 ` Shawn O. Pearce [this message]
2007-12-11 12:57 ` H.Merijn Brand
2007-12-11 9:20 ` Johannes Sixt
2007-12-11 10:42 ` H.Merijn Brand
2007-12-11 11:01 ` Johannes Sixt
2007-12-11 13:33 ` H.Merijn Brand
2007-12-11 13:53 ` Johannes Sixt
2007-12-04 15:11 ` H.Merijn Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211085440.GK14735@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=h.m.brand@xs4all.nl \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).