* [PATCH] Brown paper bag fix to previous send-email change
@ 2007-12-11 6:55 Mike Hommey
2007-12-11 7:04 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Mike Hommey @ 2007-12-11 6:55 UTC (permalink / raw
To: git; +Cc: Junio C Hamano
My previous change led to the In-Reply-To header being <> when the given
value was empty. This fixes it.
Signed-off-by: Mike Hommey <mh@glandium.org>
---
I think I have an antispam problem somewhere with this patch, because even
keeping sending it, it never reached the list. And Junio didn't answer to my
private message about it, so I guess that was some server being smart with
the subject line. *sigh*
PS: sorry Junio if you get this patch multiple time.
git-send-email.perl | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index c0e1dd3..0e8c457 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -369,8 +369,10 @@ if ($thread && !defined $initial_reply_to && $prompting) {
$initial_reply_to = $_;
}
-$initial_reply_to =~ s/^\s*<?/</;
-$initial_reply_to =~ s/>?\s*$/>/;
+if ($initial_reply_to) {
+ $initial_reply_to =~ s/^\s*<?/</;
+ $initial_reply_to =~ s/>?\s*$/>/;
+}
if (!defined $smtp_server) {
foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
--
1.5.3.7.1161.g14b8
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Brown paper bag fix to previous send-email change
2007-12-11 6:55 [PATCH] Brown paper bag fix to previous send-email change Mike Hommey
@ 2007-12-11 7:04 ` Junio C Hamano
2007-12-11 7:44 ` Mike Hommey
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2007-12-11 7:04 UTC (permalink / raw
To: Mike Hommey; +Cc: git
Mike Hommey <mh@glandium.org> writes:
> My previous change led to the In-Reply-To header being <> when the given
> value was empty. This fixes it.
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>
> I think I have an antispam problem somewhere with this patch, because even
> keeping sending it, it never reached the list. And Junio didn't answer to my
> private message about it, so I guess that was some server being smart with
> the subject line. *sigh*
>
> PS: sorry Junio if you get this patch multiple time.
No, I happened to have noticed the same and have an almost identical fix
(I said "defined $initial_reply_to") already queued in my tree.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Brown paper bag fix to previous send-email change
2007-12-11 7:04 ` Junio C Hamano
@ 2007-12-11 7:44 ` Mike Hommey
2007-12-11 8:02 ` Junio C Hamano
2007-12-11 8:06 ` Junio C Hamano
0 siblings, 2 replies; 5+ messages in thread
From: Mike Hommey @ 2007-12-11 7:44 UTC (permalink / raw
To: Junio C Hamano; +Cc: git
On Mon, Dec 10, 2007 at 11:04:36PM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > My previous change led to the In-Reply-To header being <> when the given
> > value was empty. This fixes it.
> >
> > Signed-off-by: Mike Hommey <mh@glandium.org>
> > ---
> >
> > I think I have an antispam problem somewhere with this patch, because even
> > keeping sending it, it never reached the list. And Junio didn't answer to my
> > private message about it, so I guess that was some server being smart with
> > the subject line. *sigh*
> >
> > PS: sorry Junio if you get this patch multiple time.
>
> No, I happened to have noticed the same and have an almost identical fix
> (I said "defined $initial_reply_to") already queued in my tree.
Testing "defined $initial_reply_to" might not be enough, because $initial_reply_to
can be defined and empty.
Mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Brown paper bag fix to previous send-email change
2007-12-11 7:44 ` Mike Hommey
@ 2007-12-11 8:02 ` Junio C Hamano
2007-12-11 8:06 ` Junio C Hamano
1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2007-12-11 8:02 UTC (permalink / raw
To: Mike Hommey; +Cc: git
Mike Hommey <mh@glandium.org> writes:
> On Mon, Dec 10, 2007 at 11:04:36PM -0800, Junio C Hamano wrote:
>> Mike Hommey <mh@glandium.org> writes:
>>
>> > My previous change led to the In-Reply-To header being <> when the given
>> > value was empty. This fixes it.
>> >
>> > Signed-off-by: Mike Hommey <mh@glandium.org>
>> > ---
>> >
>> > I think I have an antispam problem somewhere with this patch, because even
>> > keeping sending it, it never reached the list. And Junio didn't answer to my
>> > private message about it, so I guess that was some server being smart with
>> > the subject line. *sigh*
>> >
>> > PS: sorry Junio if you get this patch multiple time.
>>
>> No, I happened to have noticed the same and have an almost identical fix
>> (I said "defined $initial_reply_to") already queued in my tree.
>
> Testing "defined $initial_reply_to" might not be enough, because $initial_reply_to
> can be defined and empty.
And if empty what does your regexp do? Produce "<>"? How's that
useful?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Brown paper bag fix to previous send-email change
2007-12-11 7:44 ` Mike Hommey
2007-12-11 8:02 ` Junio C Hamano
@ 2007-12-11 8:06 ` Junio C Hamano
1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2007-12-11 8:06 UTC (permalink / raw
To: Mike Hommey; +Cc: git
Mike Hommey <mh@glandium.org> writes:
>> No, I happened to have noticed the same and have an almost identical fix
>> (I said "defined $initial_reply_to") already queued in my tree.
>
> Testing "defined $initial_reply_to" might not be enough, because $initial_reply_to
> can be defined and empty.
Ah, I see what you mean. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-12-11 8:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-11 6:55 [PATCH] Brown paper bag fix to previous send-email change Mike Hommey
2007-12-11 7:04 ` Junio C Hamano
2007-12-11 7:44 ` Mike Hommey
2007-12-11 8:02 ` Junio C Hamano
2007-12-11 8:06 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).