From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: Michael Witten <mfwitten@mit.edu>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-cvsexportcommit.perl: git-apply no longer needs --binary
Date: Sat, 20 Oct 2007 15:59:52 +0200 [thread overview]
Message-ID: <200710201559.53033.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <862396DD-A3EA-4850-8AE8-9E765C7FF0F2@MIT.EDU>
onsdag 17 oktober 2007 skrev Michael Witten:
>
> On 16 Oct 2007, at 9:11:48 PM, Shawn O. Pearce wrote:
>
> > Sorry, but I have to say I agree with Robin here. The tab patch
> > is large, ugly, and provides relatively little value in comparsion.
> >
> > The first rule of git development typically is "any change is bad".
> > Because anything that is already written can be assumed to already
> > be tested and in use by someone. Breaking that is bad, as then
> > they have a bad experience with git.
>
> OK. I understand.
>
> This was really preparation for a more substantial addition
> that I hope to make.
That might warrant fixing the tabs, *then*. It is nice to know that this
debate did not scare you awya from submitting patches.
> I'll just have to change one line at a time with every substantial
> patch!
Exactly :)
I wrote some more in a commet on the On tabs and spaces thread.
-- robin
next prev parent reply other threads:[~2007-10-20 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 8:08 [PATCH 1/3] git-cvsexportcommit.perl tabified Michael Witten
2007-10-16 8:08 ` [PATCH 2/3] git-cvsexportcommit.perl tmpdir removed Michael Witten
2007-10-16 8:08 ` [PATCH 3/3] git-cvsexportcommit.perl: git-apply no longer needs --binary Michael Witten
2007-10-16 13:04 ` Johannes Schindelin
2007-10-16 15:27 ` Michael Witten
2007-10-16 21:20 ` Robin Rosenberg
2007-10-16 22:13 ` Michael Witten
2007-10-16 22:49 ` Johannes Schindelin
2007-10-16 23:22 ` Michael Witten
2007-10-17 1:11 ` Shawn O. Pearce
2007-10-17 1:34 ` Michael Witten
2007-10-20 13:59 ` Robin Rosenberg [this message]
2007-10-17 2:25 ` [PATCH 2/3] git-cvsexportcommit.perl tmpdir removed Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710201559.53033.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=mfwitten@mit.edu \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).